Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed AE2 integration when AE2's channels are disabled #3134

Closed
wants to merge 1 commit into from
Closed

Fixed AE2 integration when AE2's channels are disabled #3134

wants to merge 1 commit into from

Conversation

LeiserGeist
Copy link

@LeiserGeist LeiserGeist commented Aug 1, 2019

I believe I properly fixed the issue referenced in #3090

The previous fix did not seem to correctly fix the issue, and resulted in a NoSuchElementException being thrown when attempting to connect an adapter to an AE2 ME Interface, when AE2's channels were disabled. Controllers don't exist when channels are disabled, thus the exception.

Prior to that commit, it checked if ME Controllers exist before defining the integration for both ME Controllers and ME Interfaces. For controllers this check was necessary, but not for interfaces. The fix removed the checks from both.

By re-implementing the check only when defining ME Controllers, this fixed the exception and allows ME Interfaces to be used when channels are disabled.

Sorry for the potentially poor description!

Previous fix for #3090 did not correctly fix the issue.
@LeiserGeist
Copy link
Author

LeiserGeist commented Aug 2, 2019

Heh, something's gone horribly wrong with the Travis instance that's checking these PRs

@Alexejhero
Copy link

Any clues on when this will be merged?

@LeiserGeist
Copy link
Author

Looks like this was implemented at some point, closing.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants