Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix some LuaJ bugs #371

Merged
merged 2 commits into from
Jul 5, 2014
Merged

Fix some LuaJ bugs #371

merged 2 commits into from
Jul 5, 2014

Conversation

gamax92
Copy link
Contributor

@gamax92 gamax92 commented Jul 4, 2014

LuaDouble:
Do not try Long.toString
Do not cast to float

LuaString:
Do not scan as a long
Add another check in scandouble (was scanlong)
Have substring create new bytes to work with

@gamax92
Fix some LuaJ bugs (Not tested for LuaJ 3)
6164a9f 
LuaDouble:
Do not try Long.toString
Do not cast to float

LuaString:
Do not scan as a long
Add another check in scandouble (was scanlong)
Have substring create new bytes to work with
@gamax92
Forgot an import
6616de2 
import java.util.Arrays
@gamax92 gamax92 changed the title Fix some LuaJ bugs (Not tested for LuaJ 3) Fix some LuaJ bugs Jul 4, 2014
@gamax92
Copy link
Contributor Author

gamax92 commented Jul 5, 2014

All patches have been tested in LuaJ 3 (On OpenComputers)

@fnuecke fnuecke merged commit 6616de2 into MightyPirates:master Jul 5, 2014
@fnuecke
Copy link
Member

fnuecke commented Jul 5, 2014

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@gamax92 @fnuecke