git-commit-each: expand shard handling #19
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Besides a-z shard directories, homebrew/cask also has numeric ones
like `0`, `1`, etc., as well as multi-level `font` directories like
`font/font-0`, `font/font-a`, etc. The existing patterns in
`git-commit-each` don't handle these directories, so I recently
encountered commit messages like `8/8bitdo-ultimate-software: update
url, livecheck` and `font/font-h/font-hermit: update homepage` when
using this script.
This updates `git-commit-each` to handle these directories as well.
I've set up the font pattern so it will handle the existing
`font/font-a` structure but would also handle files in `font/`
itself. That said, it appears that `sed` on macOS can't handle
optional groups like `(something)?` without enabling support for
extended regular expressions (`-E`), so I've used `{0,1}` to achieve
the same goal.
8 tasks
|
Thanks @samford! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Besides a-z shard directories, homebrew/cask also has numeric ones like
0,1, etc., as well as multi-levelfontdirectories likefont/font-0,font/font-a, etc. The existing patterns ingit-commit-eachdon't handle these directories, so I recently encountered commit messages like8/8bitdo-ultimate-software: update url, livecheckandfont/font-h/font-hermit: update homepagewhen using this script.This updates
git-commit-eachto handle these directories as well. I've set up the font pattern so it will handle the existingfont/font-astructure but would also handle files infont/itself. That said, it appears thatsedon macOS can't handle optional groups like(something)?without enabling support for extended regular expressions (-E), so I've used{0,1}to achieve the same goal.