Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

phalcon: command not found after the install #41

Merged
merged 1 commit into from
Dec 25, 2019

Conversation

VinceDZiree
Copy link
Contributor

@VinceDZiree VinceDZiree commented Dec 2, 2019

I had "phalcon: command not found" after using "sh -c usr/local/bin/docker-phalcon-install-devtools"
Had to remove ".php" at line 14 because the file doesn't have it
It installs it correctly now.

Had to remove ".php" at line 14 because the file doesn't have it
It install it correctly now.
@Jeckerson
Copy link

Confirm, I removed it in latest v3 version of devtools.

@MilesChou
Copy link
Owner

How about using PHAR?

https://github.com/phalcon/phalcon-devtools#build-phar

@MilesChou MilesChou self-assigned this Dec 3, 2019
@VinceDZiree
Copy link
Contributor Author

I only tried following "Builded Image included simple script docker-phalcon-install-devtools to install latest release of Phalcon Devtools CLI" in README.md
I didn't try using PHAR.

@MilesChou
Copy link
Owner

Write the script to build PHAR is hard, I think we can follow how to install composer.phar on Dockerfile(see Troubleshooting), here is an example:

COPY --from=phalconphp/devtools /usr/bin/phalcon /usr/bin/phalcon

Alternatively, maybe we should be compatible with the version before v3.4.1, here is an example:

if [ -f /usr/src/phalcon-devtools/phalcon.php ]; then
    ln -sf /usr/src/phalcon-devtools/phalcon.php /usr/local/bin/phalcon
else
    ln -sf /usr/src/phalcon-devtools/phalcon /usr/local/bin/phalcon
fi

@Jeckerson
Copy link

@MilesChou Your PR released in 3.4.9.

@MilesChou
Copy link
Owner

@Jeckerson Can you create a repo on Docker Hub for build the devtools image?

@MilesChou MilesChou merged commit 73df5fb into MilesChou:master Dec 25, 2019
@MilesChou
Copy link
Owner

MilesChou commented Dec 25, 2019

#37 no longer support old version, accept PR.

@VinceDZiree VinceDZiree deleted the patch-1 branch December 28, 2019 21:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants