Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rosetta offline network endpoints #10019

Merged
merged 1 commit into from
Jan 13, 2022
Merged

Rosetta offline network endpoints #10019

merged 1 commit into from
Jan 13, 2022

Conversation

bkase
Copy link
Member

@bkase bkase commented Jan 13, 2022

As required by
https://www.rosetta-api.org/docs/node_deployment.html#offline-mode-endpoints

Explain your changes:

  • Pass in the thunked graphql URI into the network route (like construction) to support offline endpoints
  • Make those two endpoints offline: /options remains relatively similar, /list lists all networks (which it should have done anyway)

Explain how you tested your changes:

  • Hit these endpoints with the relevant test-curl scripts and they still work even on a rosetta instance that is in "offline mode"

@psteckler psteckler added the ci-build-me Add this label to trigger a circle+buildkite build for this branch label Jan 13, 2022
@bkase bkase merged commit 5828e97 into rosetta-1.2.1-safe Jan 13, 2022
@bkase bkase deleted the feature/rosetta-offline-network-endpoints branch January 13, 2022 21:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@psteckler psteckler psteckler approved these changes

Assignees
No one assigned
Labels
ci-build-me Add this label to trigger a circle+buildkite build for this branch
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@bkase @psteckler