Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Housekeeping] Rename *_nonconsensus libraries to shadow their consensus counterparts #10149

Merged
merged 4 commits into from
Feb 6, 2022

Conversation

mrmr1993
Copy link
Member

@mrmr1993 mrmr1993 commented Feb 3, 2022

This PR builds upon #10148 to convert all _nonconsensus libraries' internal names into the names of the equivalent consensus libraries. This reduces part of the optcomp, and most of what remains is the code for the snarky types.

Note: Snark_params_nonconsensus was handled specially, since the previous module was equivalent to Snark_params.Tick. The Snark_params_nonconsensus library now uses name Snark_params, and the implementation within it has been renamed to Tick, so that it also matches the consensus library.

This is a no-op.

Checklist:

  • Modified the current draft of release notes with details on what is completed or incomplete within this project
  • Document code purpose, how to use it
    • Mention expected invariants, implicit constraints
  • Tests were added for the new behavior
    • Document test purpose, significance of failures
    • Test names should reflect their purpose
  • All tests pass (CI will check this if you didn't)
  • Serialized types are in stable-versioned modules
  • Does this close issues? List them

@mrmr1993 mrmr1993 added the ci-build-me Add this label to trigger a circle+buildkite build for this branch label Feb 3, 2022
@mrmr1993 mrmr1993 requested review from a team as code owners February 3, 2022 03:25
Base automatically changed from feature/tidy-up-nonconensus-part1 to compatible February 6, 2022 05:49
@mrmr1993 mrmr1993 merged commit 13c0709 into compatible Feb 6, 2022
@mrmr1993 mrmr1993 deleted the feature/tidy-up-nonconensus-part5 branch February 6, 2022 06:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ci-build-me Add this label to trigger a circle+buildkite build for this branch
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants