Remove peer reliability temp #10159
Merged
Remove peer reliability temp #10159
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
QuiteStochastic
added
the
ci-build-me
psteckler
approved these changes
Feb 5, 2022
mrmr1993
approved these changes
Feb 7, 2022
lk86
reviewed
Feb 7, 2022
| @@ -20,6 +20,7 @@ let dirtyWhen = [ | |||
| S.strictlyStart (S.contains "buildkite/src/Command/MinaArtifact"), | |||
| S.exactly "buildkite/scripts/build-artifact" "sh", | |||
| S.exactly "buildkite/scripts/connect-to-mainnet-on-compatible" "sh", | |||
| S.strictlyStart (S.contains "buildkite/src/Jobs/Test/TestnetIntegrationTest"), | |||
There was a problem hiding this comment.
I think "buildkite/src/Jobs/Test" is probably a better filter here as most testing jobs depend on these artifacts (or individually list TestnetIntegrationTests, ReplayerTest, DeployTestnetAndDestroy, MigratedIntegrationTests, ConnectToTestnet). Similarly, "buildkite/src/Command" does not depend on these jobs but has the potential to break them, so they should be dirty.
There was a problem hiding this comment.
more correctly long term the answer is probably more folders for these jobs to better reflect dependency, like if these were all under "buildkite/src/Jobs/Test/Integration/" to separate from unit tests / static analysis.
lk86
approved these changes
Feb 7, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
temporarily remove the peer reliability test