o1trace/trace-tool revival #14811
Merged
o1trace/trace-tool revival #14811
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
emberian
changed the title
emberian
requested review from
a team,
nholland94,
bkase,
aneesharaines and
mrmr1993
as code owners
the io library copies this into an internal buffer as i expected, this wasn't the source of any data corruption
emberian
force-pushed
the
fix/trace-tool
branch
from
3caeb93
to
6a675bb
Compare
nholland94
approved these changes
Jan 10, 2024
emberian
force-pushed
the
fix/trace-tool
branch
from
81bc38f
to
67eb14a
Compare
emberian
force-pushed
the
fix/trace-tool
branch
from
67eb14a
to
99bb178
Compare
|
!ci-build-me |
|
!approved-for-mainnet |
|
!ci-build-me |
|
!approved-for-mainnet |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The trace-tool is still in WIP, but this at least fixes
daemon --tracing. The trace-tool as it exists will output one row per "fiber" in our code. We can evolve it independently.