Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade to rust 1.52.1 #9076

Merged
merged 10 commits into from
Jul 6, 2021
Merged

Upgrade to rust 1.52.1 #9076

merged 10 commits into from
Jul 6, 2021

Conversation

mrmr1993
Copy link
Member

This PR depends on #9074.

This is part of upgrading from zexe to arkworks, which requires an upgrade to the latest rust (due to non-backwards-compatible typechecker changes in rust 1.49).

The changes in the marlin and zexe repos are minimal, and a build of this PR is able to connect and sync to mainnet, but this probably requires further testing to ensure that the new compiler doesn't cause issues with the existing OCaml-to-rust bindings.

Checklist:

  • Document code purpose, how to use it
    • Mention expected invariants, implicit constraints
  • Tests were added for the new behavior
    • Document test purpose, significance of failures
    • Test names should reflect their purpose
  • All tests pass (CI will check this if you didn't)
  • Serialized types are in stable-versioned modules
  • Does this close issues? List them:

@mrmr1993 mrmr1993 added the ci-build-me Add this label to trigger a circle+buildkite build for this branch label Jun 17, 2021
@mrmr1993 mrmr1993 requested review from a team as code owners June 17, 2021 22:20
Base automatically changed from feature/zexe-to-arkworks-step-3 to compatible June 21, 2021 16:16
@aneesharaines
Copy link
Contributor

@deepthiskumar to help test this change

README-dev.md Outdated Show resolved Hide resolved
@mrmr1993
Copy link
Member Author

mrmr1993 commented Jul 1, 2021

We've seen a segfault on test-labels (the net running this PR) 😭 I've pulled in #8774 to get more info if it happens again, and merged compatible to test that CI still passes against the latest changes.

This is the first memory corruption issue in 9 days of network uptime, across 8 nodes. Given the infrequency, and given that we've also seen exactly one segfault on devnet within the same period, I would prefer not to block merging this on discovering the source of that fault, especially since it may not be the cause at all.

@mrmr1993 mrmr1993 merged commit a629407 into compatible Jul 6, 2021
@mrmr1993 mrmr1993 deleted the feature/rust-upgrade branch July 6, 2021 16:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ci-build-me Add this label to trigger a circle+buildkite build for this branch
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants