Rosetta: Fast canonical lookups chain_status #9797
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The rosetta side of the equation
bkase
added
the
ci-build-me
psteckler
reviewed
Nov 10, 2021
| ON b.id = chain.parent_id AND chain.id <> chain.parent_id | ||
| ), | ||
|
|
||
| let common_sql = |
There was a problem hiding this comment.
a comment here how this is shared by query_old and query_recent would be helpful for future audiences
psteckler
reviewed
Nov 10, 2021
| let%map max_height = | ||
| Conn.find query_max_height () | ||
| in | ||
| (* buffer an epsilon of 5 just in case archive node isn't caught up *) |
There was a problem hiding this comment.
Is the criterion to distinguish old from new queries based just on the current height, or should it examine whether blocks have marked as canonical?
There was a problem hiding this comment.
yes I was thinking we should just rely on height here -- we know performing the long recursive queries in rosetta cause Postgres to choke, so I'd rather the queries fail in the case that we haven't marked things as canonical as opposed to trying the big recursive queries in that case and then fail.
psteckler
approved these changes
Nov 10, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The rosetta side of the equation
Explain your changes:
Explain how you tested your changes: