Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Lk86/locking config and read committed #9885

Merged
merged 23 commits into from
Dec 15, 2021

Conversation

lk86
Copy link
Contributor

@lk86 lk86 commented Nov 30, 2021

This PR intends to refactor the database setup steps to be easier to edit and maintain over time, as well as provides new default values for everything in src/app/rosetta/postgres.conf with up to 5 million table locks. The rosetta.conf files were also updated as one of the former fields has been deprecated. This PR also includes the changes from #9911 so that I could test them together and make sure results were equivalent to ubuntu 18.04 and results were in fact similar. My testing did not complete all the way through syncing + 0.95% reconciled after the tip but it did sync all the way with 0 reconciliation failures before an eventual crash.

…onfig is in use and to avoid deleting the postgres cluster each run
@lk86 lk86 requested a review from a team as a code owner November 30, 2021 19:41
@lk86 lk86 added the ci-build-me Add this label to trigger a circle+buildkite build for this branch label Nov 30, 2021
Copy link
Member

@bkase bkase left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you rewrite the pr description?

Copy link
Member

@bkase bkase left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me

@lk86 lk86 requested a review from a team as a code owner December 14, 2021 00:32
@lk86 lk86 merged commit f304d11 into rosetta-1.2.1-safe Dec 15, 2021
@lk86 lk86 deleted the lk86/locking-config-and-read-committed branch December 15, 2021 23:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ci-build-me Add this label to trigger a circle+buildkite build for this branch
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants