Rosetta, return error if no account #9954
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
psteckler
added
the
ci-build-me
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is in response to the
check:dataerror resulting from trying to lookup a public key that was not in the archive database.The error apparently results from an account balance query. As part of that, there was a lookup of timing info for a given public key, which was assumed to be in the database.
The fix is to try to lookup the key before any other database queries, and return
Account_not_foundif the key is not present.The timing info lookup is modified to return
Noneif the key is not present, although the fix just mentioned will prevent the timing info lookup from being called.(I will test on
devnetbefore we release this code.)