Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Switch from ktlint -> ktfmt #116

Open
eyalgu opened this issue Feb 19, 2020 · 6 comments
Open

Switch from ktlint -> ktfmt #116

eyalgu opened this issue Feb 19, 2020 · 6 comments
Assignees
Labels
discussion we are discussing what to do, usually based on some feature request or comment

Comments

@eyalgu
Copy link
Contributor

eyalgu commented Feb 19, 2020

It seems like ktlint keeps triping me up because it doesn't support running as part of the workflow (I make a small change, forget to fix some spacing then get a failure). I'd like to try out https://github.com/facebookincubator/ktfmt.
I know the maintainers and would love to give it a try

@eyalgu eyalgu added the discussion we are discussing what to do, usually based on some feature request or comment label Feb 19, 2020
@eyalgu eyalgu self-assigned this Feb 19, 2020
@ychescale9
Copy link
Contributor

Hmm looks like there's no published artifact yet and it requires maven 🙃?

@eyalgu
Copy link
Contributor Author

eyalgu commented Feb 20, 2020 via email

@tasomaniac
Copy link
Contributor

ktfmt is not a full replacement, right? ktlint is a formatter but also a linter.

@cgrushko
Copy link

@ychescale9 @eyalgu we started publishing artifacts to Maven Central: https://search.maven.org/artifact/com.facebook/ktfmt/0.12/jar

@tasomaniac correct; ktfmt is a code formatter. It's analogous to google-java-format in the Java world.

@cgrushko
Copy link

cgrushko commented May 4, 2020

diffplug/spotless#569 is bringing ktfmt to Spotless. I see Store already uses Spotless, so it should be easy to try out ktfmt.

@biratdatta
Copy link

Yeah it is a good issue, require a discussion for it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
discussion we are discussing what to do, usually based on some feature request or comment
Projects
None yet
Development

No branches or pull requests

6 participants