Update rules_ios to latest and enable bzlmod #2696
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Current blocker: Generating "rules_ios.xcodeproj"
ERROR: /Users/lpadron/Development/rules_xcodeproj/examples/rules_ios/bazel-output-base/rules_xcodeproj.noindex/build_output_base/external/rules_xcodeproj~override~internal~rules_xcodeproj_generated/generator/xcodeproj/BUILD:12:10: error loading package 'iOSApp': Unable to find package for @[unknown repo 'build_bazel_rules_apple' requested from @]//apple:versioning.bzl: The repository '@[unknown repo 'build_bazel_rules_apple' requested from @]' could not be resolved: No repository visible as '@build_bazel_rules_apple' from main repository. and referenced by '@rules_xcodeproj~override~internal~rules_xcodeproj_generated//generator/xcodeproj:xcodeproj'
ERROR: Analysis of target '@rules_xcodeproj~override~internal~rules_xcodeproj_generated//generator/xcodeproj:xcodeproj' failed; build aborted: Analysis failed✅ fixed |
luispadron
force-pushed
the
luis/update-rules_ios-use-bzlmod
branch
7 times, most recently
from
537d100
to
8358120
Compare
luispadron
changed the title
|
@brentleyjones Any tips for testing the failing job locally? I cant seem to get a failure here locally. The error is: |
|
I can look at this Monday. |
luispadron
force-pushed
the
luis/update-rules_ios-use-bzlmod
branch
2 times, most recently
from
eb925eb
to
217179c
Compare
luispadron
force-pushed
the
luis/update-rules_ios-use-bzlmod
branch
from
217179c
to
265d86f
Compare
|
Per offline, this is good to go in as is (when others approve it). |
thiagohmcruz
approved these changes
Oct 27, 2023
Signed-off-by: Luis Padron <lpadron@squareup.com>
luispadron
force-pushed
the
luis/update-rules_ios-use-bzlmod
branch
from
265d86f
to
bac6f49
Compare
|
So it now has two rules_ios CI jobs, both using rules_ios 3.1.0:
|
mattrobmattrob
approved these changes
Oct 27, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updates to use rules_ios 3.1.0 and enables bzlmod.
rules_ios is lacking support for Bazel > 6.x: bazel-ios/rules_ios#795