Add pbxnativetargets Starlark integration
#2800
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
brentleyjones
force-pushed
the
bj/add-pbxproj_partials.write_targets
branch
from
77e515b
to
a498cb2
Compare
18 tasks
Signed-off-by: Brentley Jones <github@brentleyjones.com>
brentleyjones
force-pushed
the
bj/add-pbxproj_partials.write_targets
branch
from
a498cb2
to
5c6540a
Compare
|
Tests deferred. I'll add an issue tracking adding them. |
brentleyjones
changed the title
pbxproj_partials.write_targetspbxnativetargets Starlark integration
BalestraPatrick
approved these changes
Dec 18, 2023
brentleyjones
commented
Dec 18, 2023
| actions.write(target_arguments_file, targets_args) | ||
| actions.write(top_level_target_attributes_file, top_level_targets_args) | ||
|
|
||
| # FIXME: Add test case for this |
There was a problem hiding this comment.
Leaving in for now, covered by github issue
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.