Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix script that processes feeds #310

Merged
merged 10 commits into from
Nov 7, 2023
Merged

Conversation

fredericsimard
Copy link
Contributor

Fixed many errors in how the script functions were formulated. Tested and working.

Also, minor fixes, plus ternary operator if one URL is empty, use the other.
Needed to provide an array to the entity_type value (vp, tu, sa, default ug).
Store last known provider (with default to `TO_BE_PROVIDED`), and use it as a suggestion if the cell is empty.
Possible fix for this error:
```
  File "<string>", line 1
    from tools.operations import *; update_gtfs_realtime_source(mdb_source_id="", entity_type="GTFS Realtime - Trip Updates", provider="Arlington Transit", direct_download_url="https://realtime.arlingtontransit.com/gtfsrt/trips", authentication_type="", authentication_info_url="0 or (empty) - No authentication required.", api_key_parameter_name="", license_url= Redmon Group Inc", name="", static_reference="TO_BE_PROVIDED", note="", status="", features="Active")
                                                                                                                                                                                                                                                                                                                                                                                                                                                                               ^
SyntaxError: unterminated string literal (detected at line 1)
Error: Process completed with exit code 1.
```
@fredericsimard fredericsimard self-assigned this Nov 7, 2023
Copy link
Contributor

@emmambd emmambd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@fredericsimard fredericsimard merged commit 16de625 into main Nov 7, 2023
8 checks passed
@fredericsimard fredericsimard deleted the fix-script-process-csv branch November 7, 2023 20:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants