Closes #13 - adds top-center and bottom-center notifier position options #151
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…fier position options. Updates package.json to use needed grunt-rtlcss version and to use grunt-postcss instead of the deprecated grunt-autoprefixer that no longer adds the vendor prefixes.
|
Thanks, I'll review this as soon as possible. However, this project has a commercial license and thus: Do you consent that You provide Your Contributions on an "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied, including, without limitation, any warranties or conditions of TITLE, NON- INFRINGEMENT, MERCHANTABILITY, or FITNESS FOR A PARTICULAR PURPOSE ? |
|
👍 I do |
|
Thank you, But I believe you should consent using the same account used to issue the PR. |
|
My bad! 👍 I do consent to the above statement. |
|
Awesome... Thanks! |
MohammadYounes
added a commit
that referenced
this pull request
Aug 4, 2017
Closes #13 - adds top-center and bottom-center notifier options
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also updates package.json to use needed grunt-rtlcss version (I wasn't able to get the
.ajs-prefix addition working without explicitly downgrading the the changed-to version) and to usegrunt-postcsswith theautoprefixerplugin instead of the deprecatedgrunt-autoprefixerpackage that was no longer adding the vendor prefixes.*Note: all whitespacing changes are due to my editor, Atom, performing clean up when I save files.