Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

provenance default for schema #233

Closed
wants to merge 3 commits into from
Closed

provenance default for schema #233

wants to merge 3 commits into from

Conversation

loriab
Copy link
Collaborator

@loriab loriab commented Aug 18, 2020

Description

  • provenance switched to dynamic default so qcel doesn't show in schema. still passes mypy
  • other small mypy fixes
  • necessitates pydantic jump from 1.0 to 1.5

Status

  • Code base linted
  • Ready to go

@codecov
Copy link

codecov bot commented Aug 18, 2020

Codecov Report

Merging #233 into master will decrease coverage by 0.01%.
The diff coverage is 94.73%.

@loriab
Copy link
Collaborator Author

loriab commented Sep 4, 2020

This has been subsumed into #237

@loriab loriab closed this Sep 4, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@loriab