-
Notifications
You must be signed in to change notification settings - Fork 80
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Prevent util.execute from reading output files #296
Open
anabiman
wants to merge
11
commits into
MolSSI:master
Choose a base branch
from
anabiman:execute
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from 10 commits
Commits
Show all changes
11 commits
Select commit
Hold shift + click to select a range
03f672b
execute supports not loading outfiles in memory
anabiman 01a7425
check for file existence when load_files=False
anabiman 335817e
parameterize test_disk_files for outfiles_load
anabiman 2df24d3
improve type hints, info msgs
anabiman 132f5f8
replace outfiles_load w/ outfiles_track, generalize test_disk_files
anabiman f66a88b
enable tracking/reading of individual files
anabiman 2a78064
reformat code with black
anabiman 02b9432
replace travis with GHA CI badge
anabiman 4a3e389
remove print statement
anabiman 3308c0a
outfiles_track is None by def
anabiman a3d0ace
support '*' for outfiles_track
anabiman File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
are you handling the case when
outfiles=["subdir/*"], outfiles_track=["subdir/bigfile"]
?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No, this will not work (bigfile will be loaded in memory). For
outfiles_track
to work, it has to be a subset ofoutfiles
. So for the following input:or the opposite:
outfiles_track
will be ignored. There are also no sanity checks being done onoutfiles_track
so if one specifies a filename not part ofoutfiles
, it will be ignored without any warnings.I guess the main advantage in setting
outfiles_load: bool
is we don't have to worry about individual cases like these.