Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

"mfa model" command line script fails without "github_token" argument #451

Closed
G-Thor opened this issue May 18, 2022 · 0 comments · Fixed by #458
Closed

"mfa model" command line script fails without "github_token" argument #451

G-Thor opened this issue May 18, 2022 · 0 comments · Fixed by #458

Comments

@G-Thor
Copy link
Contributor

G-Thor commented May 18, 2022

Since the argument parser in montreal_forced_aligner/command_line/model.py does not supply a default (blank) value to the github_token argument, the script errors out when this argument is not supplied due to it being undefined

Montreal-Forced-Aligner/montreal_forced_aligner/command_line/model.py

Line 167 in 4f4283c

manager = ModelManager(token=args.github_token)

@mmcauliffe mmcauliffe mentioned this issue Jun 2, 2022
Merged
mmcauliffe added a commit that referenced this issue Jun 2, 2022
@mmcauliffe
2.0.0rc8 (#458)
3944163 
Resolves #451
Resolves #450
Resolves #452
Resolves #448
Resolves #414
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

2.0.0rc8 MontrealCorpusTools/Montreal-Forced-Aligner
1 participant
@G-Thor