Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

v2.0.5 update #480

Merged
merged 1 commit into from
Jul 5, 2022
Merged

v2.0.5 update #480

merged 1 commit into from
Jul 5, 2022

Conversation

mmcauliffe
Copy link
Member

Resolves #478
Resolves #476

@codecov
Copy link

codecov bot commented Jul 5, 2022

Codecov Report

Merging #480 (0bbc054) into main (714fc16) will decrease coverage by 0.27%.
The diff coverage is 90.49%.

@@            Coverage Diff             @@
##             main     #480      +/-   ##
==========================================
- Coverage   75.32%   75.04%   -0.28%     
==========================================
  Files          72       72              
  Lines       14787    14819      +32     
  Branches     2896     2903       +7     
==========================================
- Hits        11138    11121      -17     
- Misses       2864     2908      +44     
- Partials      785      790       +5     
Impacted Files Coverage Δ
montreal_forced_aligner/g2p/generator.py 78.54% <ø> (ø)
...ntreal_forced_aligner/g2p/phonetisaurus_trainer.py 13.22% <20.00%> (+0.02%) ⬆️
...treal_forced_aligner/acoustic_modeling/triphone.py 87.29% <50.00%> (-0.91%) ⬇️
montreal_forced_aligner/acoustic_modeling/lda.py 88.07% <60.00%> (-0.77%) ⬇️
montreal_forced_aligner/acoustic_modeling/sat.py 82.51% <60.00%> (-1.38%) ⬇️
montreal_forced_aligner/dictionary/multispeaker.py 89.87% <63.63%> (-0.52%) ⬇️
montreal_forced_aligner/corpus/base.py 65.35% <80.00%> (ø)
montreal_forced_aligner/alignment/mixins.py 83.76% <80.95%> (-0.52%) ⬇️
montreal_forced_aligner/abc.py 80.85% <100.00%> (+0.04%) ⬆️
montreal_forced_aligner/acoustic_modeling/base.py 90.26% <100.00%> (+0.13%) ⬆️
... and 29 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 714fc16...0bbc054. Read the comment docs.

@mmcauliffe mmcauliffe merged commit 3315d9e into main Jul 5, 2022
@mmcauliffe mmcauliffe deleted the v2.0.5 branch July 5, 2022 04:42
@MiniXC
Copy link

MiniXC commented Jul 14, 2022

This seems makes it impossible to use lexicons without tabs without additional preprocessing, showing the following message:

Did not find any tabs, please ensure that your dictionary has tabs between words and their pronunciations.

@mmcauliffe
Copy link
Member Author

Correct, with the addition of more columns for probabilities, it's more ambiguous where the transcription begins and where the probabilities are for phone sets like xsampa that use numbers for phones.

A regex for preprocessing it is ^(\S+)\s+ replaced by \1\t or $1\t depending on the text editor.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants