-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Apply Changes without Reloading (and other fixes) #1
Conversation
-Auto Generate Templates for Toggles and Cyclers
-Mark when Colliding -Won't update till resolved -Auto Generate on Name Change
-Removed Apply Button again as no longer needed -Some Refactoring
Hey, big thanks for your pull request. Let me take a look at your work and give it a review. 😄 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The automatic changes are perfect, never knew there were functions to clear the properties of a plugin.
The bind templates are great for new people to understand how they are designed to be used. Just gives a nice starting pattern for each bind.
The quality of life improvements (auto InputMap renaming, InputMap deletion, tooltips, etc.) are perfect. I wonder if the mapping can be removed from the list too, to avoid confusion.
Duplicate naming prevention could maybe prevent the user from adding binds until the name is resolved (this check could also occur if the property name is empty), just so the created binds have sensible default names.
I've changed the import dialog to use a SimHub-specific version, just to match the software theme.
Saw the plugin pop up and thought it was interesting, saw then that I had to reload (when I know from my own plugins that this is not necessary), so thought I could solve this and a few quirks I found.
Changelog: