Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Apply Changes without Reloading (and other fixes) #1

Merged
merged 13 commits into from
Aug 18, 2022
Merged

Apply Changes without Reloading (and other fixes) #1

merged 13 commits into from
Aug 18, 2022

Conversation

LukasLichten
Copy link
Contributor

Saw the plugin pop up and thought it was interesting, saw then that I had to reload (when I know from my own plugins that this is not necessary), so thought I could solve this and a few quirks I found.

Changelog:

  • Automatically applies changes
  • Fixed being able to name two Properties (and the Binds within) the same (and cause them not to work correctly)
    • Highlighting for when names collide
  • Renaming Properties and Binds no longer unbinds InputMaps
  • Deleting Properties and Binds removes InputMaps
  • When adding a Cycler or Toggle to a Property without any maps will generate a template
    • Cycler spawns with two normal binds and a Cycler in Forward mode
    • Toggle spawns with a normal bind named Default and a Toggle named Toggle
    • If binds already exist it just adds a Cycler/Toggle
    • Binds will also generate with a default name (PropertyName_"number")
  • Added Tooltips
  • Export now exports a Indented Json for better readability
  • Added Warning to Import that it deletes existing Properties

@MorGuux MorGuux added the enhancement New feature or request label Aug 18, 2022
@MorGuux
Copy link
Owner

MorGuux commented Aug 18, 2022

Hey, big thanks for your pull request. Let me take a look at your work and give it a review. 😄

MorGuux
MorGuux previously approved these changes Aug 18, 2022
@MorGuux MorGuux marked this pull request as draft August 18, 2022 14:13
@MorGuux MorGuux marked this pull request as ready for review August 18, 2022 14:14
@MorGuux MorGuux self-requested a review August 18, 2022 14:14
@MorGuux MorGuux dismissed their stale review August 18, 2022 14:24

Still learning Git :)

Copy link
Owner

@MorGuux MorGuux left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The automatic changes are perfect, never knew there were functions to clear the properties of a plugin.

The bind templates are great for new people to understand how they are designed to be used. Just gives a nice starting pattern for each bind.

The quality of life improvements (auto InputMap renaming, InputMap deletion, tooltips, etc.) are perfect. I wonder if the mapping can be removed from the list too, to avoid confusion.

Duplicate naming prevention could maybe prevent the user from adding binds until the name is resolved (this check could also occur if the property name is empty), just so the created binds have sensible default names.

I've changed the import dialog to use a SimHub-specific version, just to match the software theme.

@MorGuux MorGuux merged commit 515ad7f into MorGuux:master Aug 18, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants