[pull] main from google:main #182
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![pull[bot]](https://avatars.githubusercontent.com/in/12910?s=60&v=4){kind=small}
Change-Id: If5d32fdb715be0b3b4ecdcf4d762ca92eb2c99d6 Reviewed-on: https://code-review.googlesource.com/c/re2/+/62670 Reviewed-by: Alex Chernyakhovsky <achernya@google.com> Reviewed-by: Paul Wankadia <junyer@google.com>
Change-Id: I06faef205ed686ed82974454fe8dffcf6b10ef91 Reviewed-on: https://code-review.googlesource.com/c/re2/+/62671 Reviewed-by: Alex Chernyakhovsky <achernya@google.com> Reviewed-by: Paul Wankadia <junyer@google.com>
Fixes #474. Change-Id: I9b93d7d8942d9da502ed79782c6a14ccaded5970 Reviewed-on: https://code-review.googlesource.com/c/re2/+/62690 Reviewed-by: Alex Chernyakhovsky <achernya@google.com> Reviewed-by: Paul Wankadia <junyer@google.com>
It now uses rules_python, which makes it drastically simpler and also means that hermetic Python toolchains are used by default. However, we want local Python toolchains to be used when building wheels, so we have to do a little dance there. Change-Id: I0dcd55522aca40aae0de0535439b714eeb85911a Reviewed-on: https://code-review.googlesource.com/c/re2/+/62710 Reviewed-by: Alex Chernyakhovsky <achernya@google.com> Reviewed-by: Paul Wankadia <junyer@google.com>
Change-Id: I3ed566fb37f235190b5fe91dfd07f575173a6aca Reviewed-on: https://code-review.googlesource.com/c/re2/+/62711 Reviewed-by: Alex Chernyakhovsky <achernya@google.com> Reviewed-by: Paul Wankadia <junyer@google.com>
Change-Id: Ie0d82540cdb7804830c7f6a9a9a3e7e33e3b38f5 Reviewed-on: https://code-review.googlesource.com/c/re2/+/62712 Reviewed-by: Alex Chernyakhovsky <achernya@google.com> Reviewed-by: Paul Wankadia <junyer@google.com>
The same warning shows up with clang++. Tested with clang-16 and clang-17. Change-Id: I4181f7eb20a17b83aef1d4d0c4a34d42818f53a1 Reviewed-on: https://code-review.googlesource.com/c/re2/+/62730 Reviewed-by: Alex Chernyakhovsky <achernya@google.com> Reviewed-by: Paul Wankadia <junyer@google.com>
Regexp::LeadingString didn't output Latin1 into flags. In the given pattern, 0xA5 should be factored out, but shouldn't lose its Latin1-ness in the process. Because that was happening, the prefix for accel was 0xC2 0xA5 instead of 0xA5. Note that the former doesn't occur in the given input and so replacements weren't occurring. Fixes #477. Change-Id: Icd36ba0905684d93d6db58e8047c9787918d0cf4 Reviewed-on: https://code-review.googlesource.com/c/re2/+/62713 Reviewed-by: Paul Wankadia <junyer@google.com> Reviewed-by: Jashank Jeremy <jashankj@google.com>
It turned out that case folding assumed UTF-8 mode, so we would fold, say, 0xD1 to 0xF1 even in Latin-1 mode. Fixes #477. Change-Id: I73aa5c8e33ee0c6041c54e3a7268635915960f64 Reviewed-on: https://code-review.googlesource.com/c/re2/+/62714 Reviewed-by: Alex Chernyakhovsky <achernya@google.com> Reviewed-by: Paul Wankadia <junyer@google.com>
Change-Id: I6adb5dcd1c0b3d3551c04867d9e3390b22694b86 Reviewed-on: https://code-review.googlesource.com/c/re2/+/62750 Reviewed-by: Perry Lorier <perryl@google.com> Reviewed-by: Paul Wankadia <junyer@google.com>
At long last, we can test the Python bindings in the CI because they should actually work on Windows as well... Change-Id: Iede307a2cc059fd3230d238e0861439971b4169f Reviewed-on: https://code-review.googlesource.com/c/re2/+/62751 Reviewed-by: Perry Lorier <perryl@google.com> Reviewed-by: Paul Wankadia <junyer@google.com>
Change-Id: I0a0966667baf39310eba885078b99200612e014e Reviewed-on: https://code-review.googlesource.com/c/re2/+/62790 Reviewed-by: Perry Lorier <perryl@google.com> Reviewed-by: Paul Wankadia <junyer@google.com>
This is very useful for setting local configurations such as extra warnings, --config, etc. Name `user.bazelrc` like bazel best practices describe it: https://bazel.build/configure/best-practices#bazelrc-file Change-Id: If531d682668b4cb2421cfba79848102964634189 Reviewed-on: https://code-review.googlesource.com/c/re2/+/62770 Reviewed-by: Paul Wankadia <junyer@google.com> Reviewed-by: Alex Chernyakhovsky <achernya@google.com>
Change-Id: Iafd06023ceaf5023a99a0d54be846d6ae8ab1035 Reviewed-on: https://code-review.googlesource.com/c/re2/+/62810 Reviewed-by: Alex Chernyakhovsky <achernya@google.com> Reviewed-by: Paul Wankadia <junyer@google.com>
... and remove Clang 15 so that we continue to test with only the three most recent releases. Change-Id: Ib1eaa20b2c988bb53027dd3e01551d5d95058e24 Reviewed-on: https://code-review.googlesource.com/c/re2/+/62830 Reviewed-by: Perry Lorier <perryl@google.com> Reviewed-by: Paul Wankadia <junyer@google.com>
While I'm here, update to the latest release. Change-Id: I785222dc8afb9b5fec838261c632f81bb24ab48c Reviewed-on: https://code-review.googlesource.com/c/re2/+/62831 Reviewed-by: Perry Lorier <perryl@google.com> Reviewed-by: Paul Wankadia <junyer@google.com>
Change generated commment to follow https://go.dev/s/generatedcode Change-Id: I61e0da6583a5f8df2da63d669388cce83ad91d0d Reviewed-on: https://code-review.googlesource.com/c/re2/+/62850 Reviewed-by: Paul Wankadia <junyer@google.com> Reviewed-by: Alex Chernyakhovsky <achernya@google.com>
Change-Id: I9fdb4ce637857acb6d7c9979a910bf35db99fa75 Reviewed-on: https://code-review.googlesource.com/c/re2/+/62870 Reviewed-by: Alex Chernyakhovsky <achernya@google.com> Reviewed-by: Paul Wankadia <junyer@google.com>
Note that this isn't the same as pinning to commits as in specifying their hashes. Note also that this isn't as ugly either. It's a minor improvement over "floating" (i.e. major version only) tags/branches. Change-Id: Id88fe81281885aff41f2625b3b71f945266c8677 Reviewed-on: https://code-review.googlesource.com/c/re2/+/62871 Reviewed-by: Alex Chernyakhovsky <achernya@google.com> Reviewed-by: Paul Wankadia <junyer@google.com>
Fixes #484. Change-Id: I152b5ed8a6358d2d74f553bde2e66f2e50cfba1d Reviewed-on: https://code-review.googlesource.com/c/re2/+/62890 Reviewed-by: Alex Chernyakhovsky <achernya@google.com> Reviewed-by: Paul Wankadia <junyer@google.com>
Fixes #485. Change-Id: Id7900ab2d034432016d425aeceb60a814225f10e Reviewed-on: https://code-review.googlesource.com/c/re2/+/62872 Reviewed-by: Paul Wankadia <junyer@google.com> Reviewed-by: Alex Chernyakhovsky <achernya@google.com>
Change-Id: Ib26837e1d2d63ce13b1ef171c5c1af8168b94448 Reviewed-on: https://code-review.googlesource.com/c/re2/+/62910 Reviewed-by: Jeff Bailey <jeffbailey@google.com> Reviewed-by: Paul Wankadia <junyer@google.com>
Otherwise, `delocate` renames the wheels! Change-Id: I03bf330332a1586deed0519b7983b1a29574ec64 Reviewed-on: https://code-review.googlesource.com/c/re2/+/62911 Reviewed-by: Jeff Bailey <jeffbailey@google.com> Reviewed-by: Paul Wankadia <junyer@google.com>
Change-Id: I4f50d5299a0462d279042a2175995fff00ff97e4 Reviewed-on: https://code-review.googlesource.com/c/re2/+/62912 Reviewed-by: Paul Wankadia <junyer@google.com> Reviewed-by: Jeff Bailey <jeffbailey@google.com>
Change-Id: I6b23bb04f0caaa2a65a23c941b1aea1eeb4da25d Reviewed-on: https://code-review.googlesource.com/c/re2/+/62913 Reviewed-by: Ash Liu <almquist@google.com> Reviewed-by: Paul Wankadia <junyer@google.com>
It was probably neither needed nor used and will start causing problems as of CMake 3.29, which removes `PACKAGE_PREFIX_DIR`. Fixes #488. Change-Id: I707dc903234309698a6745d2b61279fd3b7bd6dc Reviewed-on: https://code-review.googlesource.com/c/re2/+/62930 Reviewed-by: Paul Wankadia <junyer@google.com> Reviewed-by: Alex Chernyakhovsky <achernya@google.com>
Change-Id: I528b54aa604dcca48a915c8d87a23d7cbbe10659 Reviewed-on: https://code-review.googlesource.com/c/re2/+/62950 Reviewed-by: Jashank Jeremy <jashankj@google.com> Reviewed-by: Paul Wankadia <junyer@google.com>
Triggering off a pushed tag, it creates the corresponding release, then downloads the source code archives and uploads them as release assets using Sigstore for signature. Someday, it will be convenient to switch to using SLSA for signature and provenance, but that day is not today. Yours truly has been wanting to automate away this dance for years. In light of CVE-2024-3094, now seemed like a really good time to do that. Change-Id: I0972ae5dcae7193ef457e23553a7dbe22adbfb1c Reviewed-on: https://code-review.googlesource.com/c/re2/+/62970 Reviewed-by: Ash Liu <almquist@google.com> Reviewed-by: Paul Wankadia <junyer@google.com>
Change-Id: I5ee5e77240952d4927959e2cdbe1b2f82cfa4d92 Reviewed-on: https://code-review.googlesource.com/c/re2/+/62971 Reviewed-by: Paul Wankadia <junyer@google.com> Reviewed-by: Ash Liu <almquist@google.com>
Change-Id: Ie94c5e6931f8fa70f238c9a5360874ff8833876a Reviewed-on: https://code-review.googlesource.com/c/re2/+/62972 Reviewed-by: Perry Lorier <perryl@google.com> Reviewed-by: Paul Wankadia <junyer@google.com>
While I'm here, update @abseil-cpp to version 20240116.2. Fixes #486. Change-Id: I86ec3bd1860e2bd1424a67eb5590eaaa7cc4ea71 Reviewed-on: https://code-review.googlesource.com/c/re2/+/62990 Reviewed-by: Paul Wankadia <junyer@google.com> Reviewed-by: Alex Chernyakhovsky <achernya@google.com>
Bump versions of actions and dependencies. Change-Id: Ifb798e7c320b092e2faed2cd4d03fc962b8c009e Reviewed-on: https://code-review.googlesource.com/c/re2/+/63010 Reviewed-by: Alex Chernyakhovsky <achernya@google.com> Reviewed-by: Paul Wankadia <junyer@google.com>
The GNU make CI workflow is currently broken on macOS because the Homebrew prefix differs between X64 and ARM64. It turns out that the compiler can't find GoogleTest (and Benchmark) anymore via the default path(s). We should really have been specifying the path(s) explicitly long before now anyway. Change-Id: If526389aa89b20b64ccfcc486769050c351e759f Reviewed-on: https://code-review.googlesource.com/c/re2/+/63030 Reviewed-by: Paul Wankadia <junyer@google.com> Reviewed-by: Alex Chernyakhovsky <achernya@google.com>
IIRC, it was problematic for MSVC 2017 and/or MSVC 2019, but google/oss-policies-info@dca3ce0 raised the support baseline to MSVC 2022, so let's try it... Change-Id: Id00483381c1f6c499a2da0c2d40d235c95dedfaa Reviewed-on: https://code-review.googlesource.com/c/re2/+/63050 Reviewed-by: Alex Chernyakhovsky <achernya@google.com> Reviewed-by: Paul Wankadia <junyer@google.com>
Change-Id: Ibf4f297ccf4a198cdf663ec424d988ee2603ecc5 Reviewed-on: https://code-review.googlesource.com/c/re2/+/63051 Reviewed-by: Alex Chernyakhovsky <achernya@google.com> Reviewed-by: Paul Wankadia <junyer@google.com>
Ubuntu ships very old versions and it's cramping my style. (In particular, I want to be able to use Abseil logging.) While I'm here, add GCC 14 to the build matrix. ... and remove GCC 11 so that we continue to test with only the three most recent releases. Change-Id: If7eb226005d8d9e56d3523e6e255d29814646d10 Reviewed-on: https://code-review.googlesource.com/c/re2/+/63070 Reviewed-by: Alex Chernyakhovsky <achernya@google.com> Reviewed-by: Paul Wankadia <junyer@google.com>
vcpkg installs `libgtest_main.a` into a `manual-link` subdirectory for some reason... Change-Id: I0842281094dae10ee82e72c22c165d3a8141cbe9 Reviewed-on: https://code-review.googlesource.com/c/re2/+/63090 Reviewed-by: Alex Chernyakhovsky <achernya@google.com> Reviewed-by: Paul Wankadia <junyer@google.com>
Fixes #494. Change-Id: Ie8bd23d44a6f2609b72f115c3b2344a2a91637be Reviewed-on: https://code-review.googlesource.com/c/re2/+/63091 Reviewed-by: Alex Chernyakhovsky <achernya@google.com> Reviewed-by: Paul Wankadia <junyer@google.com>
This is done primarily for the sake of Chromium, which bans the unprefixed Abseil logging macros. I mostly baked the following slices of Perl pie: ``` 's,//absl/log:check",//absl/log:absl_check",' 's,//absl/log",//absl/log:absl_log",' 's,"absl/log/check.h","absl/log/absl_check.h",' 's,"absl/log/log.h","absl/log/absl_log.h",' 's,D?CHECK(_(EQ|NE|LE|LT|GE|GT))?\(,ABSL_$&,' 's,V?LOG\(,ABSL_$&,' ``` Change-Id: I65493aff42abab6865f8e2b5b769b6a651dbef3a Reviewed-on: https://code-review.googlesource.com/c/re2/+/63092 Reviewed-by: Paul Wankadia <junyer@google.com> Reviewed-by: Alex Chernyakhovsky <achernya@google.com>
https://gitlab.kitware.com/cmake/cmake/-/issues/16899 was reported seven years ago. The bug existed at least ten years ago. It hasn't been fixed. Change-Id: Ifbe3e77ce6371091b24303d5c4953d401ed29826 Reviewed-on: https://code-review.googlesource.com/c/re2/+/63071 Reviewed-by: Alex Chernyakhovsky <achernya@google.com> Reviewed-by: Paul Wankadia <junyer@google.com>
Change-Id: I32465e8e875a35a6e8b8fb29ad952b4a1b7293c2 Reviewed-on: https://code-review.googlesource.com/c/re2/+/63110 Reviewed-by: Alex Chernyakhovsky <achernya@google.com> Reviewed-by: Paul Wankadia <junyer@google.com>
Change-Id: Iba5a0f3a18245a22f68ba1c3d533200cc577a596 Reviewed-on: https://code-review.googlesource.com/c/re2/+/63130 Reviewed-by: Alex Chernyakhovsky <achernya@google.com> Reviewed-by: Paul Wankadia <junyer@google.com>
... and make sure it stays. Change-Id: Iab9f9e9445545a9c97aefd4d83691a70fde2b1c8 Reviewed-on: https://code-review.googlesource.com/c/re2/+/63111 Reviewed-by: Paul Wankadia <junyer@google.com> Reviewed-by: Alex Chernyakhovsky <achernya@google.com>
Change-Id: Ic0d6aa382308afbf6ccbb6c34b7fa3575443875c Reviewed-on: https://code-review.googlesource.com/c/re2/+/63150 Reviewed-by: Alex Chernyakhovsky <achernya@google.com> Reviewed-by: Paul Wankadia <junyer@google.com>
The first run for this month's release failed after uploading some of the wheels, but before uploading the sdist, so we need a way to force the sdist on a rerun if necessary. Change-Id: I3851d20cdeba02caad5f450e77cd7ef8704990d2 Reviewed-on: https://code-review.googlesource.com/c/re2/+/63170 Reviewed-by: Alex Chernyakhovsky <achernya@google.com> Reviewed-by: Paul Wankadia <junyer@google.com>
Change-Id: I453072c1a19dabc2d3ed0672ec9936d56f637f7c Reviewed-on: https://code-review.googlesource.com/c/re2/+/63210 Reviewed-by: Ash Liu <almquist@google.com> Reviewed-by: Paul Wankadia <junyer@google.com>
This is setting up to run mypy as per #496. Change-Id: I48e67387313ac01d493086be8481b34f26bafe82 Reviewed-on: https://code-review.googlesource.com/c/re2/+/63230 Reviewed-by: Alex Chernyakhovsky <achernya@google.com> Reviewed-by: Paul Wankadia <junyer@google.com>
Change-Id: I1acea938fe9fc033a65ae87a725064c1cb658839 Reviewed-on: https://code-review.googlesource.com/c/re2/+/63250 Reviewed-by: Paul Wankadia <junyer@google.com> Reviewed-by: Alex Chernyakhovsky <achernya@google.com>
We need `re2` to be a package, not a module, because it appears that modules can't have `.pyi` files, so munge the module into a package. Change-Id: I1a268875743390c32c0fb9cd58f6d83a670ce928 Reviewed-on: https://code-review.googlesource.com/c/re2/+/63270 Reviewed-by: Paul Wankadia <junyer@google.com> Reviewed-by: Alex Chernyakhovsky <achernya@google.com>
Change-Id: Ie291a4c1f1e847d9ffb86112df027cc6bc2100c2 Reviewed-on: https://code-review.googlesource.com/c/re2/+/63290 Reviewed-by: Alex Chernyakhovsky <achernya@google.com> Reviewed-by: Paul Wankadia <junyer@google.com>
Change-Id: I84b078f47e3754c0a10bc58a54cba3f3987bbb80 Reviewed-on: https://code-review.googlesource.com/c/re2/+/63330 Reviewed-by: Alex Chernyakhovsky <achernya@google.com> Reviewed-by: Paul Wankadia <junyer@google.com>
Fixes #499. Change-Id: I076d4fb4a51e0589176fdd175045ac90b0e361cb Reviewed-on: https://code-review.googlesource.com/c/re2/+/63350 Reviewed-by: Paul Wankadia <junyer@google.com> Reviewed-by: Alex Chernyakhovsky <achernya@google.com>
Fixes #499. Change-Id: I5405db7dff30ba84387c89a6064902f948b1ee3c Reviewed-on: https://code-review.googlesource.com/c/re2/+/63370 Reviewed-by: Alex Chernyakhovsky <achernya@google.com> Reviewed-by: Paul Wankadia <junyer@google.com>
Change-Id: Ia4272f8c10eb5e4d1b93049e7516d2ccd0090100 Reviewed-on: https://code-review.googlesource.com/c/re2/+/63351 Reviewed-by: Alex Chernyakhovsky <achernya@google.com> Reviewed-by: Paul Wankadia <junyer@google.com>
Change-Id: Ib1250ec954c0fecdaed606c41bbbbe00ff7bc1de Reviewed-on: https://code-review.googlesource.com/c/re2/+/63371 Reviewed-by: Paul Wankadia <junyer@google.com> Reviewed-by: Alex Chernyakhovsky <achernya@google.com>
Change-Id: Ia67342d56907053228895ed6cd65c98949bd7c43 Reviewed-on: https://code-review.googlesource.com/c/re2/+/63352 Reviewed-by: Paul Wankadia <junyer@google.com> Reviewed-by: Alex Chernyakhovsky <achernya@google.com>
|
RE2 uses Gerrit instead of GitHub pull requests. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See Commits and Changes for more details.
Created by
pull[bot]
Can you help keep this open source service alive? 💖 Please sponsor : )