[pull] main from google:main #56
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![pull[bot]](https://avatars.githubusercontent.com/in/12910?s=60&v=4){kind=small}
Change-Id: If5d32fdb715be0b3b4ecdcf4d762ca92eb2c99d6 Reviewed-on: https://code-review.googlesource.com/c/re2/+/62670 Reviewed-by: Alex Chernyakhovsky <achernya@google.com> Reviewed-by: Paul Wankadia <junyer@google.com>
Change-Id: I06faef205ed686ed82974454fe8dffcf6b10ef91 Reviewed-on: https://code-review.googlesource.com/c/re2/+/62671 Reviewed-by: Alex Chernyakhovsky <achernya@google.com> Reviewed-by: Paul Wankadia <junyer@google.com>
Fixes #474. Change-Id: I9b93d7d8942d9da502ed79782c6a14ccaded5970 Reviewed-on: https://code-review.googlesource.com/c/re2/+/62690 Reviewed-by: Alex Chernyakhovsky <achernya@google.com> Reviewed-by: Paul Wankadia <junyer@google.com>
It now uses rules_python, which makes it drastically simpler and also means that hermetic Python toolchains are used by default. However, we want local Python toolchains to be used when building wheels, so we have to do a little dance there. Change-Id: I0dcd55522aca40aae0de0535439b714eeb85911a Reviewed-on: https://code-review.googlesource.com/c/re2/+/62710 Reviewed-by: Alex Chernyakhovsky <achernya@google.com> Reviewed-by: Paul Wankadia <junyer@google.com>
Change-Id: I3ed566fb37f235190b5fe91dfd07f575173a6aca Reviewed-on: https://code-review.googlesource.com/c/re2/+/62711 Reviewed-by: Alex Chernyakhovsky <achernya@google.com> Reviewed-by: Paul Wankadia <junyer@google.com>
Change-Id: Ie0d82540cdb7804830c7f6a9a9a3e7e33e3b38f5 Reviewed-on: https://code-review.googlesource.com/c/re2/+/62712 Reviewed-by: Alex Chernyakhovsky <achernya@google.com> Reviewed-by: Paul Wankadia <junyer@google.com>
The same warning shows up with clang++. Tested with clang-16 and clang-17. Change-Id: I4181f7eb20a17b83aef1d4d0c4a34d42818f53a1 Reviewed-on: https://code-review.googlesource.com/c/re2/+/62730 Reviewed-by: Alex Chernyakhovsky <achernya@google.com> Reviewed-by: Paul Wankadia <junyer@google.com>
Regexp::LeadingString didn't output Latin1 into flags. In the given pattern, 0xA5 should be factored out, but shouldn't lose its Latin1-ness in the process. Because that was happening, the prefix for accel was 0xC2 0xA5 instead of 0xA5. Note that the former doesn't occur in the given input and so replacements weren't occurring. Fixes #477. Change-Id: Icd36ba0905684d93d6db58e8047c9787918d0cf4 Reviewed-on: https://code-review.googlesource.com/c/re2/+/62713 Reviewed-by: Paul Wankadia <junyer@google.com> Reviewed-by: Jashank Jeremy <jashankj@google.com>
It turned out that case folding assumed UTF-8 mode, so we would fold, say, 0xD1 to 0xF1 even in Latin-1 mode. Fixes #477. Change-Id: I73aa5c8e33ee0c6041c54e3a7268635915960f64 Reviewed-on: https://code-review.googlesource.com/c/re2/+/62714 Reviewed-by: Alex Chernyakhovsky <achernya@google.com> Reviewed-by: Paul Wankadia <junyer@google.com>
Change-Id: I6adb5dcd1c0b3d3551c04867d9e3390b22694b86 Reviewed-on: https://code-review.googlesource.com/c/re2/+/62750 Reviewed-by: Perry Lorier <perryl@google.com> Reviewed-by: Paul Wankadia <junyer@google.com>
At long last, we can test the Python bindings in the CI because they should actually work on Windows as well... Change-Id: Iede307a2cc059fd3230d238e0861439971b4169f Reviewed-on: https://code-review.googlesource.com/c/re2/+/62751 Reviewed-by: Perry Lorier <perryl@google.com> Reviewed-by: Paul Wankadia <junyer@google.com>
Change-Id: I0a0966667baf39310eba885078b99200612e014e Reviewed-on: https://code-review.googlesource.com/c/re2/+/62790 Reviewed-by: Perry Lorier <perryl@google.com> Reviewed-by: Paul Wankadia <junyer@google.com>
This is very useful for setting local configurations such as extra warnings, --config, etc. Name `user.bazelrc` like bazel best practices describe it: https://bazel.build/configure/best-practices#bazelrc-file Change-Id: If531d682668b4cb2421cfba79848102964634189 Reviewed-on: https://code-review.googlesource.com/c/re2/+/62770 Reviewed-by: Paul Wankadia <junyer@google.com> Reviewed-by: Alex Chernyakhovsky <achernya@google.com>
Change-Id: Iafd06023ceaf5023a99a0d54be846d6ae8ab1035 Reviewed-on: https://code-review.googlesource.com/c/re2/+/62810 Reviewed-by: Alex Chernyakhovsky <achernya@google.com> Reviewed-by: Paul Wankadia <junyer@google.com>
... and remove Clang 15 so that we continue to test with only the three most recent releases. Change-Id: Ib1eaa20b2c988bb53027dd3e01551d5d95058e24 Reviewed-on: https://code-review.googlesource.com/c/re2/+/62830 Reviewed-by: Perry Lorier <perryl@google.com> Reviewed-by: Paul Wankadia <junyer@google.com>
While I'm here, update to the latest release. Change-Id: I785222dc8afb9b5fec838261c632f81bb24ab48c Reviewed-on: https://code-review.googlesource.com/c/re2/+/62831 Reviewed-by: Perry Lorier <perryl@google.com> Reviewed-by: Paul Wankadia <junyer@google.com>
|
RE2 uses Gerrit instead of GitHub pull requests. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See Commits and Changes for more details.
Created by
pull[bot]
Can you help keep this open source service alive? 💖 Please sponsor : )