Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[pull] main from google:main #72

Closed
wants to merge 21 commits into from
Closed

[pull] main from google:main #72

wants to merge 21 commits into from

Commits on Feb 13, 2024

  1. Try using p0deje/setup-bazel everywhere.

    Change-Id: If5d32fdb715be0b3b4ecdcf4d762ca92eb2c99d6
    Reviewed-on: https://code-review.googlesource.com/c/re2/+/62670
    Reviewed-by: Alex Chernyakhovsky <achernya@google.com>
    Reviewed-by: Paul Wankadia <junyer@google.com>
    junyer committed Feb 13, 2024
    Configuration menu
    Copy the full SHA
    731086c View commit details
    Browse the repository at this point in the history
  2. Bump version of p0deje/setup-bazel to address warnings.

    Change-Id: I06faef205ed686ed82974454fe8dffcf6b10ef91
    Reviewed-on: https://code-review.googlesource.com/c/re2/+/62671
    Reviewed-by: Alex Chernyakhovsky <achernya@google.com>
    Reviewed-by: Paul Wankadia <junyer@google.com>
    junyer committed Feb 13, 2024
    Configuration menu
    Copy the full SHA
    b4c6fe0 View commit details
    Browse the repository at this point in the history

Commits on Feb 15, 2024

  1. Update @apple_support to version 1.12.0.

    Fixes #474.
    
    Change-Id: I9b93d7d8942d9da502ed79782c6a14ccaded5970
    Reviewed-on: https://code-review.googlesource.com/c/re2/+/62690
    Reviewed-by: Alex Chernyakhovsky <achernya@google.com>
    Reviewed-by: Paul Wankadia <junyer@google.com>
    junyer committed Feb 15, 2024
    Configuration menu
    Copy the full SHA
    ed9fc26 View commit details
    Browse the repository at this point in the history

Commits on Feb 16, 2024

  1. Update @pybind11_bazel to version 2.11.1.bzl.2.

    It now uses rules_python, which makes it drastically simpler
    and also means that hermetic Python toolchains are used by
    default. However, we want local Python toolchains to be used
    when building wheels, so we have to do a little dance there.
    
    Change-Id: I0dcd55522aca40aae0de0535439b714eeb85911a
    Reviewed-on: https://code-review.googlesource.com/c/re2/+/62710
    Reviewed-by: Alex Chernyakhovsky <achernya@google.com>
    Reviewed-by: Paul Wankadia <junyer@google.com>
    junyer committed Feb 16, 2024
    Configuration menu
    Copy the full SHA
    2aa303b View commit details
    Browse the repository at this point in the history
  2. Avoid invalid escape sequence errors on Windows.

    Change-Id: I3ed566fb37f235190b5fe91dfd07f575173a6aca
    Reviewed-on: https://code-review.googlesource.com/c/re2/+/62711
    Reviewed-by: Alex Chernyakhovsky <achernya@google.com>
    Reviewed-by: Paul Wankadia <junyer@google.com>
    junyer committed Feb 16, 2024
    Configuration menu
    Copy the full SHA
    d00d1e9 View commit details
    Browse the repository at this point in the history

Commits on Feb 19, 2024

  1. Clean up uses of repo_name in MODULE.bazel.

    Change-Id: Ie0d82540cdb7804830c7f6a9a9a3e7e33e3b38f5
    Reviewed-on: https://code-review.googlesource.com/c/re2/+/62712
    Reviewed-by: Alex Chernyakhovsky <achernya@google.com>
    Reviewed-by: Paul Wankadia <junyer@google.com>
    junyer committed Feb 19, 2024
    Configuration menu
    Copy the full SHA
    477b9f9 View commit details
    Browse the repository at this point in the history
  2. Disable warning for missing-field-initializers as well for clang.

    The same warning shows up with clang++. Tested with clang-16 and clang-17.
    
    Change-Id: I4181f7eb20a17b83aef1d4d0c4a34d42818f53a1
    Reviewed-on: https://code-review.googlesource.com/c/re2/+/62730
    Reviewed-by: Alex Chernyakhovsky <achernya@google.com>
    Reviewed-by: Paul Wankadia <junyer@google.com>
    Henner Zeller authored and junyer committed Feb 19, 2024
    Configuration menu
    Copy the full SHA
    6bb550b View commit details
    Browse the repository at this point in the history
  3. Fix an ancient bug in prefix factoring.

    Regexp::LeadingString didn't output Latin1 into flags.
    In the given pattern, 0xA5 should be factored out, but
    shouldn't lose its Latin1-ness in the process. Because
    that was happening, the prefix for accel was 0xC2 0xA5
    instead of 0xA5. Note that the former doesn't occur in
    the given input and so replacements weren't occurring.
    
    Fixes #477.
    
    Change-Id: Icd36ba0905684d93d6db58e8047c9787918d0cf4
    Reviewed-on: https://code-review.googlesource.com/c/re2/+/62713
    Reviewed-by: Paul Wankadia <junyer@google.com>
    Reviewed-by: Jashank Jeremy <jashankj@google.com>
    junyer committed Feb 19, 2024
    Configuration menu
    Copy the full SHA
    0ff0fab View commit details
    Browse the repository at this point in the history
  4. Fix more ancient bugs around Latin-1 handling.

    It turned out that case folding assumed UTF-8 mode, so
    we would fold, say, 0xD1 to 0xF1 even in Latin-1 mode.
    
    Fixes #477.
    
    Change-Id: I73aa5c8e33ee0c6041c54e3a7268635915960f64
    Reviewed-on: https://code-review.googlesource.com/c/re2/+/62714
    Reviewed-by: Alex Chernyakhovsky <achernya@google.com>
    Reviewed-by: Paul Wankadia <junyer@google.com>
    junyer committed Feb 19, 2024
    Configuration menu
    Copy the full SHA
    f9550c3 View commit details
    Browse the repository at this point in the history

Commits on Feb 29, 2024

  1. Prepare to tag release 2024-03-01.

    Change-Id: I6adb5dcd1c0b3d3551c04867d9e3390b22694b86
    Reviewed-on: https://code-review.googlesource.com/c/re2/+/62750
    Reviewed-by: Perry Lorier <perryl@google.com>
    Reviewed-by: Paul Wankadia <junyer@google.com>
    junyer committed Feb 29, 2024
    Configuration menu
    Copy the full SHA
    2d866a3 View commit details
    Browse the repository at this point in the history

Commits on Mar 4, 2024

  1. Update @pybind11_bazel to version 2.11.1.bzl.3.

    At long last, we can test the Python bindings in the CI
    because they should actually work on Windows as well...
    
    Change-Id: Iede307a2cc059fd3230d238e0861439971b4169f
    Reviewed-on: https://code-review.googlesource.com/c/re2/+/62751
    Reviewed-by: Perry Lorier <perryl@google.com>
    Reviewed-by: Paul Wankadia <junyer@google.com>
    junyer committed Mar 4, 2024
    Configuration menu
    Copy the full SHA
    45c9985 View commit details
    Browse the repository at this point in the history
  2. Disable MSYS/MSYS2 path conversion, which interferes with Bazel.

    Change-Id: I0a0966667baf39310eba885078b99200612e014e
    Reviewed-on: https://code-review.googlesource.com/c/re2/+/62790
    Reviewed-by: Perry Lorier <perryl@google.com>
    Reviewed-by: Paul Wankadia <junyer@google.com>
    junyer committed Mar 4, 2024
    Configuration menu
    Copy the full SHA
    8695a63 View commit details
    Browse the repository at this point in the history
  3. Use try-import to load an optional user-specific user.bazelrc

    This is very useful for setting local configurations such as
    extra warnings, --config, etc.
    
    Name `user.bazelrc` like bazel best practices describe it:
    https://bazel.build/configure/best-practices#bazelrc-file
    
    Change-Id: If531d682668b4cb2421cfba79848102964634189
    Reviewed-on: https://code-review.googlesource.com/c/re2/+/62770
    Reviewed-by: Paul Wankadia <junyer@google.com>
    Reviewed-by: Alex Chernyakhovsky <achernya@google.com>
    hzeller authored and junyer committed Mar 4, 2024
    Configuration menu
    Copy the full SHA
    dbf15a2 View commit details
    Browse the repository at this point in the history

Commits on Mar 7, 2024

  1. Delete an old comment.

    Change-Id: Iafd06023ceaf5023a99a0d54be846d6ae8ab1035
    Reviewed-on: https://code-review.googlesource.com/c/re2/+/62810
    Reviewed-by: Alex Chernyakhovsky <achernya@google.com>
    Reviewed-by: Paul Wankadia <junyer@google.com>
    junyer committed Mar 7, 2024
    Configuration menu
    Copy the full SHA
    27536b0 View commit details
    Browse the repository at this point in the history

Commits on Mar 11, 2024

  1. Add Clang 18 to the build matrix.

    ... and remove Clang 15 so that we continue to
    test with only the three most recent releases.
    
    Change-Id: Ib1eaa20b2c988bb53027dd3e01551d5d95058e24
    Reviewed-on: https://code-review.googlesource.com/c/re2/+/62830
    Reviewed-by: Perry Lorier <perryl@google.com>
    Reviewed-by: Paul Wankadia <junyer@google.com>
    junyer committed Mar 11, 2024
    Configuration menu
    Copy the full SHA
    ddb3414 View commit details
    Browse the repository at this point in the history
  2. p0deje/setup-bazel has been transferred to bazel-contrib.

    While I'm here, update to the latest release.
    
    Change-Id: I785222dc8afb9b5fec838261c632f81bb24ab48c
    Reviewed-on: https://code-review.googlesource.com/c/re2/+/62831
    Reviewed-by: Perry Lorier <perryl@google.com>
    Reviewed-by: Paul Wankadia <junyer@google.com>
    junyer committed Mar 11, 2024
    Configuration menu
    Copy the full SHA
    108914d View commit details
    Browse the repository at this point in the history

Commits on Mar 17, 2024

  1. doc/mksyntaxgo: use standard generated Go header

    Change generated commment to follow https://go.dev/s/generatedcode
    
    Change-Id: I61e0da6583a5f8df2da63d669388cce83ad91d0d
    Reviewed-on: https://code-review.googlesource.com/c/re2/+/62850
    Reviewed-by: Paul Wankadia <junyer@google.com>
    Reviewed-by: Alex Chernyakhovsky <achernya@google.com>
    alexandear authored and junyer committed Mar 17, 2024
    Configuration menu
    Copy the full SHA
    58f6cdd View commit details
    Browse the repository at this point in the history
  2. Fix the link to the Python wrapper.

    Change-Id: I9fdb4ce637857acb6d7c9979a910bf35db99fa75
    Reviewed-on: https://code-review.googlesource.com/c/re2/+/62870
    Reviewed-by: Alex Chernyakhovsky <achernya@google.com>
    Reviewed-by: Paul Wankadia <junyer@google.com>
    junyer committed Mar 17, 2024
    Configuration menu
    Copy the full SHA
    5c5c8ed View commit details
    Browse the repository at this point in the history
  3. Bump versions of actions to latest releases.

    Note that this isn't the same as pinning to commits as in specifying
    their hashes. Note also that this isn't as ugly either. It's a minor
    improvement over "floating" (i.e. major version only) tags/branches.
    
    Change-Id: Id88fe81281885aff41f2625b3b71f945266c8677
    Reviewed-on: https://code-review.googlesource.com/c/re2/+/62871
    Reviewed-by: Alex Chernyakhovsky <achernya@google.com>
    Reviewed-by: Paul Wankadia <junyer@google.com>
    junyer committed Mar 17, 2024
    Configuration menu
    Copy the full SHA
    db46d1e View commit details
    Browse the repository at this point in the history

Commits on Mar 18, 2024

  1. Raise re2.error instead of crashing.

    Fixes #484.
    
    Change-Id: I152b5ed8a6358d2d74f553bde2e66f2e50cfba1d
    Reviewed-on: https://code-review.googlesource.com/c/re2/+/62890
    Reviewed-by: Alex Chernyakhovsky <achernya@google.com>
    Reviewed-by: Paul Wankadia <junyer@google.com>
    junyer committed Mar 18, 2024
    Configuration menu
    Copy the full SHA
    1250a99 View commit details
    Browse the repository at this point in the history
  2. Make compiling a no-op if it's attempted before adding any patterns.

    Fixes #485.
    
    Change-Id: Id7900ab2d034432016d425aeceb60a814225f10e
    Reviewed-on: https://code-review.googlesource.com/c/re2/+/62872
    Reviewed-by: Paul Wankadia <junyer@google.com>
    Reviewed-by: Alex Chernyakhovsky <achernya@google.com>
    junyer committed Mar 18, 2024
    Configuration menu
    Copy the full SHA
    6598a8e View commit details
    Browse the repository at this point in the history