Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Quilt support #4

Merged
merged 2 commits into from
Apr 23, 2022
Merged

Quilt support #4

merged 2 commits into from
Apr 23, 2022

Conversation

kb-1000
Copy link
Contributor

@kb-1000 kb-1000 commented Apr 26, 2021

This has been verified to generate successfully, based on the JSON content only 0.13.1-rc.3 seems to be correct (the others are missing quilt-json5, or, in the case of 0.12.0, are even still referencing Fabric).
I'll verify whether the generated component for 0.13.1-rc.3 works later.

@jamierocks
Copy link

Why this pr over GH-3?

@kb-1000
Copy link
Contributor Author

kb-1000 commented Apr 26, 2021

I haven't actually noticed #3 before.
However, I just tested it, and it does not seem to be able to generate meta successfully (looks like wrong maven URLs)

@ImperatorStorm
Copy link

I haven't actually noticed #3 before.
However, I just tested it, and it does not seem to be able to generate meta successfully (looks like wrong maven URLs)

should be fixed

@kb-1000 kb-1000 marked this pull request as ready for review April 20, 2022 17:39
@peterix peterix merged commit 40e0441 into MultiMC:master Apr 23, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants