Fix workflow for PR integration #120
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ubuntu/windows-latest: unchanged macos-latest (separated workflow file): - shell without login (otherwise the used python version is not the requested one) - source conda before env activation (this step is required if shell is without login) - export SYSTEM_VERSION_COMPAT=0 before conda activate, taken from google-deepmind/mujoco#1004
|
Thanks @andreh1111 for fixing this! Would it be possible to integrate all changes in only one file? it would be easier to add test and maintain it in the long term |
Vittorio-Caggiano
requested changes
Dec 5, 2023
| conda info | ||
| CONDA_DEFAULT_ENV=test_myosuite | ||
| conda create --name $CONDA_DEFAULT_ENV python=3.8 -y | ||
| source /usr/local/miniconda/etc/profile.d/conda.sh |
There was a problem hiding this comment.
wouldn't this work in Win/Linux?
There was a problem hiding this comment.
nope, in Windows doesn't work while in Linux the path is different. Of course the single-file is doable but the result would be verbose, at least with this solution.
Comment on lines
70
to
71
| export SYSTEM_VERSION_COMPAT=0 | ||
| source /usr/local/miniconda/etc/profile.d/conda.sh |
There was a problem hiding this comment.
would this be different in Win/Linux?
The implementation is different w.r.t. the previous commit, but the focus is the same, and the obtained workflow is more similar to the original version. Note: setting "python-version: 3.8" in miniconda setup for ubuntu-latest result in "mujoco.FatalError: gladLoadGL error", even if "MUJOCO_GL=egl" is set as env variable.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ubuntu/windows-latest: unchanged
macos-latest (separated workflow file):