indexer, graphql: remove pg_integration feature flag usage #19295
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
3 Skipped Deployments
|
bmwill
requested review from
amnn,
wlmyng,
stefan-mysten,
emmazzz and
suiwombat
as code owners
lxfind
reviewed
Sep 10, 2024
| @@ -33,8 +33,8 @@ use tokio::task::JoinHandle; | |||
| use tokio_util::sync::CancellationToken; | |||
| use tracing::info; | |||
|
|
|||
| const VALIDATOR_COUNT: usize = 7; | |||
| const EPOCH_DURATION_MS: u64 = 15000; | |||
| const VALIDATOR_COUNT: usize = 4; | |||
There was a problem hiding this comment.
The default for all of our other tests is 4, so 7 just results in more load during the test for little value since we aren't even interested in testing the validator portion of the stack. I found that this helped reduced timeouts when these tests were run when the GitHub actions runner was under high load.
| @@ -16,7 +16,7 @@ datatest_stable::harness!(run_test, TEST_DIR, r".*\.(mvir|move)$"); | |||
| #[cfg_attr(msim, msim::main)] | |||
| async fn run_test(path: &Path) -> Result<(), Box<dyn std::error::Error>> { | |||
| telemetry_subscribers::init_for_testing(); | |||
| if cfg!(feature = "pg_integration") { | |||
| if !cfg!(msim) { | |||
There was a problem hiding this comment.
Can you add a comment on this if? Don't quite understand it.
There was a problem hiding this comment.
Yeah, essentially these tests don't really work under msim since they rely on external things like a database so this shuts them off during those tests.
lxfind
approved these changes
Sep 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Describe the changes or additions included in this PR.
Test plan
How did you test the new or updated feature?
Release notes
Check each box that your changes affect. If none of the boxes relate to your changes, release notes aren't required.
For each box you select, include information after the relevant heading that describes the impact of your changes that a user might notice and any actions they must take to implement updates.