Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[TS SDK] Changes to add mutable field to Object Args #7991

Merged
merged 4 commits into from
Feb 5, 2023
Merged

[TS SDK] Changes to add mutable field to Object Args #7991

merged 4 commits into from
Feb 5, 2023

Conversation

healthydeve
Copy link
Contributor

@healthydeve healthydeve commented Feb 1, 2023 •
edited
Loading

reverted previous commit to ignore mutable field.

Added the new mutable field with backwards compatibility

@vercel
Copy link

vercel bot commented Feb 1, 2023 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated
explorer ✅ Ready (Inspect) Visit Preview 💬 Add your feedback Feb 5, 2023 at 8:36AM (UTC)
frenemies ✅ Ready (Inspect) Visit Preview 💬 Add your feedback Feb 5, 2023 at 8:36AM (UTC)
wallet-adapter ✅ Ready (Inspect) Visit Preview 💬 Add your feedback Feb 5, 2023 at 8:36AM (UTC)
1 Ignored Deployment
Name Status Preview Comments Updated
explorer-storybook ⬜️ Ignored (Inspect) Feb 5, 2023 at 8:36AM (UTC)

@github-actions
Copy link
Contributor

github-actions bot commented Feb 1, 2023 •
edited
Loading

⚠️ 🦋 Changesets Warning: This PR has changes to public npm packages, but does not contain a changeset. You can create a changeset easily by running pnpm changeset in the root of the Sui repo, and following the prompts. If your change does not need a changeset (e.g. a documentation-only change), you can ignore this message. This warning will be removed when a changeset is added to this pull request.

Learn more about Changesets.

@github-actions github-actions bot added the Type: Documentation Improvements or additions to documentation label Feb 2, 2023
@github-actions github-actions bot removed the Type: Documentation Improvements or additions to documentation label Feb 2, 2023
@healthydeve healthydeve marked this pull request as ready for review February 3, 2023 20:44
666lcz
666lcz approved these changes Feb 5, 2023
View reviewed changes
Copy link
Contributor

@666lcz 666lcz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Please address the inline comment and fix the lint errors(in CI) before merging

sdk/typescript/src/signers/txn-data-serializers/call-arg-serializer.ts Outdated
if (initialSharedVersion) {
return { Shared: { objectId, initialSharedVersion } };
const object_args = api?.major === 0 && api?.minor < 24
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
const object_args = api?.major === 0 && api?.minor < 24
const object_args = api?.major === 0 && api?.minor < 25

We should update this to 25

changing spec to include 0.24.0
24dcc4a 
adding spec to .23

fixing specs for the versions

linting and removing comments

linting and version fixing

more linter

used prettier formatter
@healthydeve healthydeve merged commit 7250911 into MystenLabs:main Feb 5, 2023
@healthydeve healthydeve deleted the mutable branch February 7, 2023 20:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@666lcz 666lcz 666lcz approved these changes

@amnn amnn Awaiting requested review from amnn

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@healthydeve @666lcz