Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Override meta tags #8

Merged
merged 1 commit into from
Oct 5, 2023
Merged

chore: Override meta tags #8

merged 1 commit into from
Oct 5, 2023

Conversation

jonandernovella
Copy link
Collaborator

Related issue(s) and PR(s)

This PR closes NBISweden/mimir#22

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Other

List of changes made

-Override meta tags previously defined by npm package details

Testing

  • Restart the services
  • Inspect the DOM and see how the description and name tags are now the ones defined in the config file

Definition of Done checklist

  • I have made an effort making the commit history understandable
  • I have performed a self-review of my own code and commented any hard-to-understand areas
  • Tests and lint/format validations are passing
  • My changes generate no new warnings
  • Make sure layout and text follows design sketches, if there are any

@jhagberg jhagberg merged commit ccfa79f into develop Oct 5, 2023
@jhagberg jhagberg deleted the fix/meta-tags branch October 5, 2023 11:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Site description should reference NBIS
2 participants