Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Run django tests #17

Merged
merged 2 commits into from
Sep 21, 2023
Merged

feat: Run django tests #17

merged 2 commits into from
Sep 21, 2023

Conversation

jonandernovella
Copy link
Collaborator

Related issue(s) and PR(s)

This PR closes #16

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Other

List of changes made

  • Added minimal action to run unit tests

Testing

  • Check the actions tab of the PR and make sure the tests pass

Definition of Done checklist

  • I have made an effort making the commit history understandable
  • I have performed a self-review of my own code and commented any hard-to-understand areas
  • Tests and lint/format validations are passing
  • My changes generate no new warnings
  • Make sure layout and text follows design sketches, if there are any

Copy link
Contributor

@jhagberg jhagberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The AC is not fulfilled here.

Please demonstrate a failing test run also as agreed

@jonandernovella
Copy link
Collaborator Author

@jhagberg Here is the link to the failing action: https://github.com/NBISweden/mimir/actions/runs/6262424722/job/17004552372

@jhagberg jhagberg merged commit 9bb4efc into develop Sep 21, 2023
2 checks passed
@jhagberg jhagberg deleted the dev/test-run branch September 21, 2023 14:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

feat: Run tests in CI/CD
2 participants