-
Notifications
You must be signed in to change notification settings - Fork 65
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update default behaviors #425
Merged
mdeceglie
merged 21 commits into
aggregated_filters_for_trials
from
new_default_behavior
Aug 21, 2024
Merged
Update default behaviors #425
mdeceglie
merged 21 commits into
aggregated_filters_for_trials
from
new_default_behavior
Aug 21, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## aggregated_filters_for_trials #425 +/- ##
=================================================================
- Coverage 96.10% 96.09% -0.02%
=================================================================
Files 11 11
Lines 2206 2200 -6
=================================================================
- Hits 2120 2114 -6
Misses 86 86 ☔ View full report in Codecov by Sentry. |
mdeceglie
changed the title
Turn on two way window filter by default
Update default behaviors
Jul 11, 2024
This is ready for review. I snuck in a few changes in the requirements files. Even though the checks were passing, I was having trouble getting the environment to install locally. |
martin-springer
approved these changes
Aug 20, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
__init__.py