Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update default behaviors #425

Merged
merged 21 commits into from
Aug 21, 2024
Merged

Conversation

mdeceglie
Copy link
Collaborator

@mdeceglie mdeceglie commented Jul 10, 2024

  • Code changes are covered by tests
  • Code changes have been evaluated for compatibility/integration with TrendAnalysis
  • New functions added to __init__.py
  • API.rst is up to date, along with other sphinx docs pages
  • Example notebooks are rerun and differences in results scrutinized
  • Updated changelog

@codecov-commenter
Copy link

codecov-commenter commented Jul 10, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 96.09%. Comparing base (e4349b1) to head (131bd43).

Additional details and impacted files
@@                        Coverage Diff                        @@
##           aggregated_filters_for_trials     #425      +/-   ##
=================================================================
- Coverage                          96.10%   96.09%   -0.02%     
=================================================================
  Files                                 11       11              
  Lines                               2206     2200       -6     
=================================================================
- Hits                                2120     2114       -6     
  Misses                                86       86              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@mdeceglie mdeceglie changed the title Turn on two way window filter by default Update default behaviors Jul 11, 2024
@mdeceglie
Copy link
Collaborator Author

This is ready for review. I snuck in a few changes in the requirements files. Even though the checks were passing, I was having trouble getting the environment to install locally.

@mdeceglie mdeceglie merged commit d6969ea into aggregated_filters_for_trials Aug 21, 2024
16 checks passed
@mdeceglie mdeceglie deleted the new_default_behavior branch August 21, 2024 15:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants