fix lose user interaction when app make ephemeral window. #29
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…loading indicator
|
Wow, thank you so much! I've been meaning to look into this for some time now but haven't gotten around to it. I'm surprised it was this simple of a fix. |
|
Thanks for merging. |
NSExceptional
pushed a commit
that referenced
this pull request
Oct 22, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi @NSExceptional
Capturing (strong reference) UIWindow is sometimes make a problem for example lose user interaction and eternal showing network loading progress window (PayPay.app; It is mentioned at #13 (comment) by me).
This PR fix that issue by UIWindow deallocation timing control back to application using weak reference to window.
Maybe address the #13 issue.