Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Task] Set up integration tests for Merlin example notebooks #343

Open
1 of 21 tasks
karlhigley opened this issue May 27, 2022 · 4 comments
Open
1 of 21 tasks

[Task] Set up integration tests for Merlin example notebooks #343

karlhigley opened this issue May 27, 2022 · 4 comments
Assignees
Milestone

Comments

@karlhigley
Copy link
Contributor

karlhigley commented May 27, 2022

Problem:

  • Currently, we have unit tests that cover partial dataset for the example notebooks. We cannot guarantee that example notebooks will be functional for the full dataset.

Goal:

  • Integration tests that will confirm that example notebooks will be fully functional against the full data set.

Constraints:

  • Previously, framework support for TF, PyT and HCTR was available only in NVTabular. With the recent architectural changes support must be made available in Merlin systems. Currently only TF support is available.

Starting Point:

  • Create support for HugeCTR in Merlin Systems for inference
  • Create support for Pytorch in Merlin Systems for inference
  • Refactor integration tests in NVTabular, to remove all non feature processing.
  • Create e2e example notebook for HugeCTR in merlin repo
  • Create e2e example notebook for Pytorch in merlin repo
  • Create CI for hugectr e2e notebook example in merlin repo
  • Create CI for pytorch e2e notebook example in merlin repo
  • Create jobs to run integration tests on different GPU architectures(?)
  • Create jobs to run integration tests on different multi-GPU architectures(?)
  • Create new system for reporting metrics to ASVDB
  • Refactor integration tests to report captured metrics
  • Setup system to display ASVDB metric (internally)
  • Create DLs for ASVDB notifications - per repo (PIC, SIC, ??)
  • Hook in appropriate DLs for Monitored metrics

All

Merlin Models

Merlin Systems

Merlin

@karlhigley karlhigley changed the title Set up integration tests for Merlin example notebooks [RMP] Set up integration tests for Merlin example notebooks May 27, 2022
benfred added a commit to NVIDIA-Merlin/NVTabular that referenced this issue Jun 21, 2022
With the change to the new unified container, we were pulling in more integration
tests that previously hadn't been included. This changes back to the set of
stable tests that we were using previously.

Adding the remaining integration tests is tracked for 22.07 release as part
of NVIDIA-Merlin/Merlin#343
benfred added a commit to NVIDIA-Merlin/NVTabular that referenced this issue Jun 21, 2022
With the change to the new unified container, we were pulling in more integration
tests that previously hadn't been included. This changes back to the set of
stable tests that we were using previously.

Adding the remaining integration tests is tracked for 22.07 release as part
of NVIDIA-Merlin/Merlin#343
@karlhigley karlhigley added this to the Merlin 22.07 milestone Jun 23, 2022
@viswa-nvidia
Copy link

@karlhigley @bschifferer , please add details such as the problem, goal and constraints. Let me know from a task perspective whether this ticket captures everything.

@viswa-nvidia
Copy link

We need input on who will be assigned to these tasks in this ticket.

@viswa-nvidia
Copy link

viswa-nvidia commented Jul 25, 2022

@viswa-nvidia follow up with Julio and check off done items. Review during the CI sync

@bschifferer
Copy link
Contributor

I do not understand this Roadmap ticket. I think the ticket should be setup and cleanup integration tests for EXISTING Merlin example notebooks. The ticket contains too many requests/examples, which are standalone features and not only integration tests.

I think we need to create following Roadmap tickets
Inference Support for HugeCTR in Merlin Systems:

  • Create support for HugeCTR in Merlin Systems for inference -> This is a feature of Merlin Systems to support HugeCTR
  • Create e2e example notebook for HugeCTR in merlin repo -> This is adding an example for the new feature
  • Create CI for hugectr e2e notebook example in merlin repo -> This adds the integration test for the new example

Only the last point is an integration test task. This should be an own ticket with the 3 bullets. Otherwise, we would have one Roadmap ticket Setup unittest for Merlin and it contains developing the feature, examples, unittest, etc etc.

Similar:
Support for PyTorch Inference in Merlin Systems:

  • Create support for Pytorch in Merlin Systems for inference -> This is a feature of Merlin Systems to support PyTorch
  • Create e2e example notebook for Pytorch in merlin repo -> This is adding the example for the new features`. Is the e2e example using Merlin Models or native PyTorch? If we need Merlin Models PyTorch support first, we need to extend the ticket.
  • Create CI for pytorch e2e notebook example in merlin repo -> This adds integration test for the new example

@viswa-nvidia viswa-nvidia changed the title [RMP] Set up integration tests for Merlin example notebooks [Task] Set up integration tests for Merlin example notebooks Jul 29, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants