-
Notifications
You must be signed in to change notification settings - Fork 113
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Unit test for Building and deploying multi-stage Recsys nbs #288
Conversation
Check out this pull request on See visual diffs & provide feedback on Jupyter Notebooks. Powered by ReviewNB |
Click to view CI ResultsGitHub pull request #288 of commit 3fca4a55f53ddcbf00b603312241c8247ca0db80, no merge conflicts. Running as SYSTEM Setting status of 3fca4a55f53ddcbf00b603312241c8247ca0db80 to PENDING with url https://10.20.13.93:8080/job/merlin_merlin/67/console and message: 'Pending' Using context: Jenkins Building on master in workspace /var/jenkins_home/workspace/merlin_merlin using credential systems-login > git rev-parse --is-inside-work-tree # timeout=10 Fetching changes from the remote Git repository > git config remote.origin.url https://github.com/NVIDIA-Merlin/Merlin # timeout=10 Fetching upstream changes from https://github.com/NVIDIA-Merlin/Merlin > git --version # timeout=10 using GIT_ASKPASS to set credentials login for merlin-systems > git fetch --tags --force --progress -- https://github.com/NVIDIA-Merlin/Merlin +refs/pull/288/*:refs/remotes/origin/pr/288/* # timeout=10 > git rev-parse 3fca4a55f53ddcbf00b603312241c8247ca0db80^{commit} # timeout=10 Checking out Revision 3fca4a55f53ddcbf00b603312241c8247ca0db80 (detached) > git config core.sparsecheckout # timeout=10 > git checkout -f 3fca4a55f53ddcbf00b603312241c8247ca0db80 # timeout=10 Commit message: "finalize unit test for poc" > git rev-list --no-walk 9986c55414dc25f4850609bf13c3c18d590a6832 # timeout=10 [merlin_merlin] $ /bin/bash /tmp/jenkins4879076780585032791.sh ============================= test session starts ============================== platform linux -- Python 3.8.10, pytest-7.1.2, pluggy-1.0.0 rootdir: /var/jenkins_home/workspace/merlin_merlin/merlin plugins: xdist-2.5.0, forked-1.4.0, cov-3.0.0 collected 1 item |
Documentation preview |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can we make this link dynamic as well?
/Merlin/examples/Building-and-deploying-multi-stage-RecSys/02-Deploying-multi-stage-RecSys-with-Merlin-Systems.ipynb
with REPO_ROOT
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks good - just the change of the dynamic path for the 2nd notebook
thanks. agreed. let me fix it. |
Click to view CI ResultsGitHub pull request #288 of commit 885366f0ef77f0e14cfbe3eace95d65da4d0473c, no merge conflicts. Running as SYSTEM Setting status of 885366f0ef77f0e14cfbe3eace95d65da4d0473c to PENDING with url https://10.20.13.93:8080/job/merlin_merlin/69/console and message: 'Pending' Using context: Jenkins Building on master in workspace /var/jenkins_home/workspace/merlin_merlin using credential systems-login > git rev-parse --is-inside-work-tree # timeout=10 Fetching changes from the remote Git repository > git config remote.origin.url https://github.com/NVIDIA-Merlin/Merlin # timeout=10 Fetching upstream changes from https://github.com/NVIDIA-Merlin/Merlin > git --version # timeout=10 using GIT_ASKPASS to set credentials login for merlin-systems > git fetch --tags --force --progress -- https://github.com/NVIDIA-Merlin/Merlin +refs/pull/288/*:refs/remotes/origin/pr/288/* # timeout=10 > git rev-parse 885366f0ef77f0e14cfbe3eace95d65da4d0473c^{commit} # timeout=10 Checking out Revision 885366f0ef77f0e14cfbe3eace95d65da4d0473c (detached) > git config core.sparsecheckout # timeout=10 > git checkout -f 885366f0ef77f0e14cfbe3eace95d65da4d0473c # timeout=10 Commit message: "fix dynamic path for the 2nd notebook" > git rev-list --no-walk 5d44453e548cf5cbae36fa8b5d4015b003dc2f70 # timeout=10 [merlin_merlin] $ /bin/bash /tmp/jenkins2160694068793927292.sh ============================= test session starts ============================== platform linux -- Python 3.8.10, pytest-7.1.2, pluggy-1.0.0 rootdir: /var/jenkins_home/workspace/merlin_merlin/merlin plugins: xdist-2.5.0, forked-1.4.0, cov-3.0.0 collected 1 item |
Co-authored-by: Ben Frederickson <github@benfrederickson.com>
… into unit_test_poc
No description provided.