Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

error run pointnet.py #103

Closed
rancheng opened this issue Mar 13, 2020 · 1 comment
Closed

error run pointnet.py #103

rancheng opened this issue Mar 13, 2020 · 1 comment

Comments

@rancheng
Copy link
Contributor

rancheng commented Mar 13, 2020

The model inconsistency happens in multiple places, until now I still can not have a smooth run on the example of pointnet.py

I installed minkowski==0.4.0 in my system with CUDA 10.1

https://github.com/StanfordVL/MinkowskiEngine/blob/a1fab7a14564d77245be57a9cc789e69f14c482a/examples/pointnet.py#L84-L88

here the error shows that the class ME.MinkowskiInstanceNorm doesn't have dimension argument.

But when navigate into file MinkowskiEngine/MinkowskiInstanceNorm.py

https://github.com/StanfordVL/MinkowskiEngine/blob/a1fab7a14564d77245be57a9cc789e69f14c482a/MinkowskiEngine/MinkowskiNormalization.py#L310-L318

There's still dimension here. I don't know why you delete this argument or will it break other models if we restore those arguments.

Another problem is that in here:

https://github.com/StanfordVL/MinkowskiEngine/blob/a1fab7a14564d77245be57a9cc789e69f14c482a/examples/pointnet.py#L82

Do you mean:

self.broadcast = ME.MinkowskiBroadcastMultiplication()

and if so, your tensor should be reshaped into 3x3 rather than left as 1x9

I have modified the code and I can open a pull request if it helps.

@chrischoy
Copy link
Contributor

chrischoy commented Mar 14, 2020

Thanks for submitting the issue.
I found a few problems with the code and it now works.
Please pull from the latest source for the update.

Also, please let me know if you have further questions.

Tanazzah pushed a commit to Tanazzah/MinkowskiEngine that referenced this issue Feb 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants