Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

API Notation Problem #126

Closed
SwagJ opened this issue Apr 14, 2020 · 2 comments
Closed

API Notation Problem #126

SwagJ opened this issue Apr 14, 2020 · 2 comments

Comments

@SwagJ
Copy link

SwagJ commented Apr 14, 2020

Hi,

When I tried to use the dense attribute of class SparseTensor.
https://stanfordvl.github.io/MinkowskiEngine/sparse_tensor.html
I think the notation about dimension is wrong? I created a batced coord tensor with the following value:
tensor([[ 1., 66., 58., 63.],
[ 1., 10., 39., 33.],
[ 1., 64., 96., 58.],
[ 1., 80., 34., 91.],
[ 1., 96., 62., 98.],
[ 1., 16., 30., 57.],
[ 1., 66., 92., 96.],
[ 1., 13., 6., 59.],
[ 1., 47., 23., 36.],
[ 1., 15., 30., 21.]])
And feature of all ones with size(10,1)
After used dense() on the sparseTensor created.
I got dimension like this:
torch.Size([2, 1, 87, 91, 78]),
which makes for sense to me as (batch dim, feature_dim, spatial_dim) instead of (batch dim, spatial_dim, feature_dim) marked in the API.

Also, I have an additional question. For MinkowskiConvolution, is that possible to get different coordinates from input as output? For example apply an offset along one dimension of coordinate?
Thank you very much!

@chrischoy
Copy link
Contributor

Got it thanks for catching this.

You can use arbitrary coordinates for both input and output.
Please refer to https://github.com/StanfordVL/MinkowskiEngine/blob/master/tests/conv_on_coords.py#L78 for details.

@SwagJ
Copy link
Author

SwagJ commented May 1, 2020

Thanks a lot!

@SwagJ SwagJ closed this as completed May 1, 2020
chrischoy added a commit that referenced this issue May 1, 2020
Tanazzah pushed a commit to Tanazzah/MinkowskiEngine that referenced this issue Feb 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants