-
Notifications
You must be signed in to change notification settings - Fork 68
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Broken Tutorial: single_gpu_tutorial.ipynb #105
Comments
Thanks for opening @axelmagn. You're indeed right that the function has drifted since the tutorial was initially written. In this case I'm in favor of having a default for cc: @miguelusque if you have any opinions. |
Hi @ayushdg , I think you are right. Setting it to I will change that method to have a default value of |
Signed-off-by: Nicole Luo <nluo@nvidia.com>
Fixed via #102. |
tutorials/single_node_tutorial/single_gpu_tutorial.ipynb
section 5.3 contains a line:which produces the following error:
I've checked the corresponding function, and it does indeed require a input_meta argument. However it's missing a docstring and I'm not sure what form this argument should take.
I suspect that the signature of this function has drifted since the tutorial was written. Maybe consider giving input_meta a default value (if possible), or if not, writing some docstrings for these functions?
The text was updated successfully, but these errors were encountered: