Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

single_gpu_tutorial.ipynb fails to run on GPU #183

Closed
ronjer30 opened this issue Aug 5, 2024 · 3 comments
Closed

single_gpu_tutorial.ipynb fails to run on GPU #183

ronjer30 opened this issue Aug 5, 2024 · 3 comments
Labels
bug Something isn't working

Comments

@ronjer30
Copy link
Contributor

ronjer30 commented Aug 5, 2024

Describe the bug

The single gpu tutorial notebook fails to launch a GPU based Dask cluster

Steps/Code to reproduce bug

  1. Launch notebook
  2. Run all steps in 0.Env Setup section
  3. Navigate to 4.Exact Deduplication section
  4. Launch GPU Dask cluster by running the following code in the cell
client = get_client(cluster_type = 'gpu', set_torch_to_use_rmm=False)
print(f"Number of dask worker:{get_num_workers(client)}")
client.run(pre_imports)

Returns the following error

NotImplementedError: 
        NeMo Curator does not support query planning yet.
        Please disable query planning before importing
        `dask.dataframe` or `dask_cudf`. This can be done via:
        `export DASK_DATAFRAME__QUERY_PLANNING=False`, or
        importing `dask.dataframe/dask_cudf` after importing
        `nemo_curator`.

Expected behavior
The execution should succeed and output should resemble the below
Number of dask worker:1 {'tcp://127.0.0.1:36179': None}

**Environment overview **

  • Environment location: Bare-metal
  • Method of NeMo-Curator install: Docker
docker run \
   --rm \
   -it \
   --gpus '"device=1"' \
   --ipc=host --ulimit memlock=-1 --ulimit stack=67108864 \
   -p 8888:8888 \
   -p 8787:8787 \
   nvcr.io/nvidia/nemo:dev

Additional context
Setting the following env variable in the notebook's env setup step resolves the issue
os.environ["DASK_DATAFRAME__QUERY_PLANNING"] = "False"

@ronjer30 ronjer30 added the bug Something isn't working label Aug 5, 2024
@sarahyurick
Copy link
Collaborator

Thanks! Yes, as you mentioned current fix should be to add

%env DASK_DATAFRAME__QUERY_PLANNING=False

as the first cell of the notebook. We can update the notebook accordingly.

@sarahyurick
Copy link
Collaborator

For more context, this was originally introduced in #107. There is another PR #139 currently open to support NeMo Curator with query planning but we are waiting to add it until after we do some larger scale tests.

nicoleeeluo added a commit to nicoleeeluo/NeMo-Curator that referenced this issue Aug 15, 2024
Signed-off-by: Nicole Luo <nluo@nvidia.com>
ryantwolf pushed a commit that referenced this issue Aug 15, 2024
Signed-off-by: Nicole Luo <nluo@nvidia.com>
yyu22 pushed a commit to yyu22/NeMo-Curator that referenced this issue Oct 9, 2024
Signed-off-by: Nicole Luo <nluo@nvidia.com>
Signed-off-by: Yang Yu <yayu@nvidia.com>
yyu22 pushed a commit to yyu22/NeMo-Curator that referenced this issue Oct 10, 2024
Signed-off-by: Nicole Luo <nluo@nvidia.com>
@sarahyurick
Copy link
Collaborator

Closed by #207.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants