Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[DOC] Incorrect reference to domain_classifier_example.py #91

Closed
miguelusque opened this issue May 30, 2024 · 0 comments · Fixed by #92
Closed

[DOC] Incorrect reference to domain_classifier_example.py #91

miguelusque opened this issue May 30, 2024 · 0 comments · Fixed by #92
Labels
bug Something isn't working

Comments

@miguelusque
Copy link
Contributor

Describe the bug

Here and here can be found stale references to domain_api_example.py file. That file has been renamed to domain_classifier_example.

Steps/Code to reproduce bug

Just navigate to the links to double check.

Expected behavior

Pointing to the right file.

Additional context

I will submit a PR to fix this one.
@miguelusque miguelusque added the bug Something isn't working label May 30, 2024
miguelusque added a commit to miguelusque/nemo-curator that referenced this issue May 30, 2024
@miguelusque
Fix NVIDIA#91 - Incorrect reference to domain_classifier_example.py
3055b1c 
Fix NVIDIA#91

There is a reference to a wrong path/file in this document.

This commit fixes it.

Signed-off-by: Miguel Martínez <26169771+miguelusque@users.noreply.github.com>
@miguelusque miguelusque mentioned this issue May 30, 2024
Merged
3 tasks
VibhuJawa pushed a commit that referenced this issue May 30, 2024
@miguelusque
Fix #91 - Incorrect reference to domain_classifier_example.py (#92)
30416e0 
Fix #91

There is a reference to a wrong path/file in this document.

This commit fixes it.

Signed-off-by: Miguel Martínez <26169771+miguelusque@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix #91 - Incorrect reference to domain_classifier_example.py miguelusque/nemo-curator
1 participant
@miguelusque