Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix 69 - Refactor how arguments are added to scripts #102

Merged
merged 25 commits into from
Jul 1, 2024
Merged

Fix 69 - Refactor how arguments are added to scripts #102

merged 25 commits into from
Jul 1, 2024

Commits on Jun 10, 2024

  1. Refactor arguments usage 

    Signed-off-by: Miguel Martínez <miguelusque@users.noreply.github.com>
    @miguelusque
    miguelusque committed Jun 10, 2024
    Configuration menu
    Copy the full SHA
    e0adc47 View commit details
    Browse the repository at this point in the history

  2. Refactor arguments usage 

    Signed-off-by: miguelusque <miguelusque@users.noreply.github.com>
    @miguelusque
    miguelusque committed Jun 10, 2024
    Configuration menu
    Copy the full SHA
    816e7fb View commit details
    Browse the repository at this point in the history

  3. Refactor arguments usage 

    Signed-off-by: miguelusque <miguelusque@users.noreply.github.com>
    @miguelusque
    miguelusque committed Jun 10, 2024
    Configuration menu
    Copy the full SHA
    052e25a View commit details
    Browse the repository at this point in the history

  4. Refactor arguments usage 

    Signed-off-by: miguelusque <miguelusque@users.noreply.github.com>
    @miguelusque
    miguelusque committed Jun 10, 2024
    Configuration menu
    Copy the full SHA
    21c71e1 View commit details
    Browse the repository at this point in the history

  5. Refactor arguments usage 

    Signed-off-by: miguelusque <miguelusque@users.noreply.github.com>
    @miguelusque
    miguelusque committed Jun 10, 2024
    Configuration menu
    Copy the full SHA
    66be5f7 View commit details
    Browse the repository at this point in the history

  6. Refactor arguments usage 

    Signed-off-by: miguelusque <miguelusque@users.noreply.github.com>
    @miguelusque
    miguelusque committed Jun 10, 2024
    Configuration menu
    Copy the full SHA
    38ca0ca View commit details
    Browse the repository at this point in the history

  7. Refactor arguments usage 

    Signed-off-by: miguelusque <miguelusque@users.noreply.github.com>
    @miguelusque
    miguelusque committed Jun 10, 2024
    Configuration menu
    Copy the full SHA
    e74aa04 View commit details
    Browse the repository at this point in the history

Commits on Jun 14, 2024

  1. Add missing parser 

    Signed-off-by: miguelusque <miguelusque@users.noreply.github.com>
    @miguelusque
    miguelusque committed Jun 14, 2024
    Configuration menu
    Copy the full SHA
    812f777 View commit details
    Browse the repository at this point in the history

  2. Add missing parser 

    Signed-off-by: miguelusque <miguelusque@users.noreply.github.com>
    @miguelusque
    miguelusque committed Jun 14, 2024
    Configuration menu
    Copy the full SHA
    742406d View commit details
    Browse the repository at this point in the history

Commits on Jun 18, 2024

  1. Fix missing default parameter 

    Signed-off-by: miguelusque <miguelusque@users.noreply.github.com>
    @miguelusque
    miguelusque committed Jun 18, 2024
    Configuration menu
    Copy the full SHA
    93c8a29 View commit details
    Browse the repository at this point in the history

  2. Move unique arguments to their corresponding scripts 

    Signed-off-by: miguelusque <miguelusque@users.noreply.github.com>
    @miguelusque
    miguelusque committed Jun 18, 2024
    Configuration menu
    Copy the full SHA
    3fb851f View commit details
    Browse the repository at this point in the history

  3. Merge branch 'NVIDIA:main' into miguelusque-fix-69

    @miguelusque
    miguelusque authored Jun 18, 2024
    Configuration menu
    Copy the full SHA
    843149f View commit details
    Browse the repository at this point in the history

Commits on Jun 25, 2024

  1. Update help message 

    The former message was out of date.

Co-authored-by: Ryan Wolf <ryantwolf1@gmail.com>
Signed-off-by: Miguel Martínez <26169771+miguelusque@users.noreply.github.com>
    @miguelusque @ryantwolf
    miguelusque and ryantwolf authored Jun 25, 2024
    Configuration menu
    Copy the full SHA
    990c1c0 View commit details
    Browse the repository at this point in the history

  2. Improve help wording 

    Improve help wording for output_data_dir argument

Co-authored-by: Ryan Wolf <ryantwolf1@gmail.com>
Signed-off-by: Miguel Martínez <26169771+miguelusque@users.noreply.github.com>
    @miguelusque @ryantwolf
    miguelusque and ryantwolf authored Jun 25, 2024
    Configuration menu
    Copy the full SHA
    1bd0ef4 View commit details
    Browse the repository at this point in the history

  3. Update help wording 

    Update help wording for ouptut-data-dir argument

Co-authored-by: Ryan Wolf <ryantwolf1@gmail.com>
Signed-off-by: Miguel Martínez <26169771+miguelusque@users.noreply.github.com>
    @miguelusque @ryantwolf
    miguelusque and ryantwolf authored Jun 25, 2024
    Configuration menu
    Copy the full SHA
    ed542b8 View commit details
    Browse the repository at this point in the history

  4. Update nemo_curator/scripts/text_cleaning.py 

    Co-authored-by: Ryan Wolf <ryantwolf1@gmail.com>
Signed-off-by: Miguel Martínez <26169771+miguelusque@users.noreply.github.com>
    @miguelusque @ryantwolf
    miguelusque and ryantwolf authored Jun 25, 2024
    Configuration menu
    Copy the full SHA
    653db8e View commit details
    Browse the repository at this point in the history

  5. Update nemo_curator/scripts/make_data_shards.py 

    Co-authored-by: Ryan Wolf <ryantwolf1@gmail.com>
Signed-off-by: Miguel Martínez <26169771+miguelusque@users.noreply.github.com>
    @miguelusque @ryantwolf
    miguelusque and ryantwolf authored Jun 25, 2024
    Configuration menu
    Copy the full SHA
    7d59d65 View commit details
    Browse the repository at this point in the history

  6. Fix help wording typo 

    There is a typo in help for argument output-model

Co-authored-by: Ryan Wolf <ryantwolf1@gmail.com>
Signed-off-by: Miguel Martínez <26169771+miguelusque@users.noreply.github.com>
    @miguelusque @ryantwolf
    miguelusque and ryantwolf authored Jun 25, 2024
    Configuration menu
    Copy the full SHA
    63f0744 View commit details
    Browse the repository at this point in the history

  7. Improve help wording for output-data-dir argument 

    Signed-off-by: miguelusque <miguelusque@users.noreply.github.com>
    @miguelusque
    miguelusque committed Jun 25, 2024
    Configuration menu
    Copy the full SHA
    4ba9280 View commit details
    Browse the repository at this point in the history

  8. Remove unused arguments 

    Signed-off-by: miguelusque <miguelusque@users.noreply.github.com>
    @miguelusque
    miguelusque committed Jun 25, 2024
    Configuration menu
    Copy the full SHA
    d9407b2 View commit details
    Browse the repository at this point in the history

  9. Fix help wording 

    Signed-off-by: miguelusque <miguelusque@users.noreply.github.com>
    @miguelusque
    miguelusque committed Jun 25, 2024
    Configuration menu
    Copy the full SHA
    3a1bd09 View commit details
    Browse the repository at this point in the history

  10. Remove unneeded print 

    Signed-off-by: miguelusque <miguelusque@users.noreply.github.com>
    @miguelusque
    miguelusque committed Jun 25, 2024
    Configuration menu
    Copy the full SHA
    35e47a4 View commit details
    Browse the repository at this point in the history

  11. Fix help string for output-data-dir argument 

    Signed-off-by: miguelusque <miguelusque@users.noreply.github.com>
    @miguelusque
    miguelusque committed Jun 25, 2024
    Configuration menu
    Copy the full SHA
    d86308c View commit details
    Browse the repository at this point in the history

  12. Improve argument passing 

    Signed-off-by: miguelusque <miguelusque@users.noreply.github.com>
    @miguelusque
    miguelusque committed Jun 25, 2024
    Configuration menu
    Copy the full SHA
    2980420 View commit details
    Browse the repository at this point in the history

Commits on Jun 26, 2024

  1. Revert changes 

    Signed-off-by: Miguel Martínez <26169771+miguelusque@users.noreply.github.com>
    @miguelusque
    miguelusque authored Jun 26, 2024
    Configuration menu
    Copy the full SHA
    1a36735 View commit details
    Browse the repository at this point in the history