Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pin to numpy<2 to avoid spacy compat issues #119

Merged
merged 1 commit into from
Jun 18, 2024

Conversation

ayushdg
Copy link
Collaborator

@ayushdg ayushdg commented Jun 18, 2024

Description

Fixes current CI test failures: https://github.com/NVIDIA/NeMo-Curator/actions/runs/9544784088/job/26340303080?pr=117

Usage

N/A

Checklist

  • I am familiar with the Contributing Guide.
  • New or Existing tests cover these changes.
  • The documentation is up to date with these changes.

Signed-off-by: Ayush Dattagupta <ayushdg95@gmail.com>
@ayushdg ayushdg requested a review from ryantwolf June 18, 2024 02:50
@ayushdg ayushdg mentioned this pull request Jun 18, 2024
@ryantwolf
Copy link
Collaborator

Good with me. The NeMo Framework container has been using numpy 1.24 so nothing should break there.

@ryantwolf ryantwolf merged commit 9da54b8 into NVIDIA:main Jun 18, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants