Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add pre-commit style checks #14

Merged
merged 2 commits into from
Mar 25, 2024
Merged

Add pre-commit style checks #14

merged 2 commits into from
Mar 25, 2024

Conversation

ayushdg
Copy link
Collaborator

@ayushdg ayushdg commented Mar 21, 2024

  1. Add pre-commit-config
  2. Fix some circular imports in the codebase
  3. Move pytest and other black/isort configs to pyproject.toml

@ayushdg
Updates for pre-commit CI tests, add black, isort and other pre commi…
b3ed243 
…t configs

Signed-off-by: Ayush Dattagupta <ayushdg95@gmail.com>
@ayushdg ayushdg marked this pull request as ready for review March 21, 2024 22:58
@ayushdg ayushdg requested a review from ryantwolf March 21, 2024 22:58
ryantwolf
ryantwolf approved these changes Mar 22, 2024
View reviewed changes
Copy link
Collaborator

@ryantwolf ryantwolf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Unit tests are passing, and I can't find anything wrong after skimming the files the unit tests don't cover.

@ayushdg
Fix circular imports
a6d7aac 
Co-authored-by: Ryan Wolf <rywolf@nvidia.com>
Signed-off-by: Ayush Dattagupta <ayushdg95@gmail.com>

[pre-commit.ci] auto fixes from pre-commit.com hooks

for more information, see https://pre-commit.ci

Add copyright & update py_version to 310

Signed-off-by: Ayush Dattagupta <ayushdg95@gmail.com>
@ryantwolf ryantwolf merged commit 1c73ade into main Mar 25, 2024
3 checks passed
@ryantwolf ryantwolf deleted the ayushdg/ci/style-check branch March 25, 2024 19:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ryantwolf ryantwolf ryantwolf approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ayushdg @ryantwolf