Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Noisy CUDA Shutdown #20

Merged
merged 3 commits into from
Apr 2, 2024
Merged

Fix Noisy CUDA Shutdown #20

merged 3 commits into from
Apr 2, 2024

Conversation

ryantwolf
Copy link
Collaborator

Addresses #8

Signed-off-by: Ryan Wolf <rywolf@nvidia.com>
Signed-off-by: Ryan Wolf <rywolf@nvidia.com>
Copy link
Collaborator

@VibhuJawa VibhuJawa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

from .exact_dedup import ExactDuplicates
from .filter import Filter, Score, ScoreFilter
from .fuzzy_dedup import LSH, MinHash
from .meta import Sequential
from .modify import Modify
from .task import TaskDecontamination

# This import must come after all imports that require cugraph
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
# This import must come after all imports that require cugraph
# Pytorch related imports must come after all imports that require cugraph, because of context cleanup issues b/w pytorch and cugraph

Signed-off-by: Ryan Wolf <rywolf@nvidia.com>
@ryantwolf ryantwolf merged commit 35d5f8f into main Apr 2, 2024
3 checks passed
@ryantwolf ryantwolf deleted the rywolf/noisy-cuda-fix branch April 2, 2024 00:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants