-
Notifications
You must be signed in to change notification settings - Fork 68
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Pin Rapids to 24.8 for 0.5.0 Release #273
Pin Rapids to 24.8 for 0.5.0 Release #273
Conversation
Signed-off-by: Praateek Mahajan <praateekm@gmail.com>
Signed-off-by: Praateek Mahajan <praateekm@gmail.com>
Signed-off-by: Praateek Mahajan <praateekm@gmail.com>
Signed-off-by: Praateek Mahajan <praateekm@gmail.com>
requirements/requirements.txt
Outdated
@@ -14,7 +14,6 @@ justext==3.0.1 | |||
lxml_html_clean | |||
mwparserfromhell==0.6.5 | |||
nemo_toolkit[nlp]>=1.23.0 | |||
numpy<2 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do you just want to have numpy
without any pin instead of removing it entirely?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Don't have opinions on when we want something to be explicitly defined here or be picked up as a dependency from one of the N packages being installed which also depend on numpy. If anything I'd say let's remove it altogether but not strongly opinionated.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We should also hold off on merging until we can run some gpu tests locally + Nemo ci (if it has any tests using spacy features). Just to ensure nothing on the gpu+ spacy end changed.
Signed-off-by: Praateek Mahajan <praateekm@gmail.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is the plan to add an upper pin to spacy for now and investigate removing the numpy pin completely in a followup?
Description
Since our release is planned for 2nd week of October, and Rapids might do a 24.10 release by 10th Oct