Fix #53 - Add batched files reading support to separate_by_metadata script #54
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…g performance This commit fixes issue NVIDIA#43 (empty files created when invoking reshard_jsonl method at nemo_curator.utils.file_utils.py) by double-checking the files size after being generated, and deleting them with size zero. In addition to that, I have noticed there is no need to parse to JSON object the content of the different lines, which should be already in json format. By removing that extra-parsing, there is a significant speed up in the execution of this method. Signed-off-by: Miguel Martínez <26169771+miguelusque@users.noreply.github.com>
Fix issue NVIDIA#43 (empty files creation) and improve reading/writing speed
In order to reduce potential OOMs, I have added support to batched files reading. Signed-off-by: Miguel Martínez <26169771+miguelusque@users.noreply.github.com>
Fixed some style errors Signed-off-by: Miguel Martínez <26169771+miguelusque@users.noreply.github.com>
I should have not pushed these changes in this PR. Sorry Signed-off-by: Miguel Martínez <26169771+miguelusque@users.noreply.github.com>
|
Please, do not review this PR yet. There is something wrong when writing metadata to this. I will fix it asap. Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added batched files reading support to separate_by_metadata.py, in order to avoid OOMs.
In the current implementation, all the files are read at once, and distributed to the workers.
With this approach, only a batch of them are sent to the workers at once.