Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add pull request template #78

Merged
merged 4 commits into from
May 22, 2024
Merged

Add pull request template #78

merged 4 commits into from
May 22, 2024

Conversation

ayushdg
Copy link
Collaborator

@ayushdg ayushdg commented May 22, 2024

Description

Adds a PR template in the following format.

Usage

N/A

Checklist

  • I am familiar with the Contributing Guide.
  • New or Existing tests cover these changes.
  • The documentation is up to date with these changes.

Signed-off-by: Ayush Dattagupta <ayushdg95@gmail.com>
Signed-off-by: Ayush Dattagupta <ayushdg95@gmail.com>
Signed-off-by: Ayush Dattagupta <ayushdg95@gmail.com>
@ayushdg ayushdg requested a review from ryantwolf May 22, 2024 22:07
@ryantwolf
Copy link
Collaborator

@ayushdg it looks like there is an awkward amount of extra whitespace between the first checklist item and the rest, can you fix that?

Signed-off-by: Ayush Dattagupta <ayushdg95@gmail.com>
Copy link
Collaborator

@ryantwolf ryantwolf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ayushdg ayushdg merged commit 0af4a98 into NVIDIA:main May 22, 2024
3 checks passed
@ayushdg ayushdg deleted the pr-template branch June 3, 2024 17:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants