Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve Common Crawl download #82

Merged
merged 9 commits into from
Jun 28, 2024
Merged

Improve Common Crawl download #82

merged 9 commits into from
Jun 28, 2024

Conversation

ryantwolf
Copy link
Collaborator

@ryantwolf ryantwolf commented May 24, 2024

Description

Improves the download_common_crawl utility by adding more error handling and throwing more descriptive errors.
Closes #80 .

Usage

Usage is the same as before.

Checklist

  • I am familiar with the Contributing Guide.
  • New or Existing tests cover these changes.
  • The documentation is up to date with these changes.

Signed-off-by: Ryan Wolf <rywolf@nvidia.com>
Signed-off-by: Ryan Wolf <rywolf@nvidia.com>
Signed-off-by: Ryan Wolf <rywolf@nvidia.com>
Signed-off-by: Ryan Wolf <rywolf@nvidia.com>
Signed-off-by: Ryan Wolf <rywolf@nvidia.com>
@ryantwolf ryantwolf requested a review from ayushdg May 24, 2024 20:43
Copy link
Collaborator

@sarahyurick sarahyurick left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Added very minor comments, but I think this can be merged as is too.

docs/user-guide/download.rst Outdated Show resolved Hide resolved
tests/test_download.py Show resolved Hide resolved
Signed-off-by: Ryan Wolf <rywolf@nvidia.com>
Signed-off-by: Ryan Wolf <rywolf@nvidia.com>
Signed-off-by: Ryan Wolf <rywolf@nvidia.com>
@ryantwolf ryantwolf merged commit 3d57926 into main Jun 28, 2024
3 checks passed
@ryantwolf ryantwolf deleted the rywolf/improve-download branch June 28, 2024 22:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[FEA] Improve download and extract utility
2 participants