Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

LICENSE mismatch #74

Closed
paroque28 opened this issue Jan 30, 2020 · 4 comments
Closed

LICENSE mismatch #74

paroque28 opened this issue Jan 30, 2020 · 4 comments

Comments

@paroque28
Copy link

There are four different licenses in the repository:

  • BSD
  • APACHE 2
  • GPL 3
  • Nvidia commercial
@RenaudWasTaken
Copy link
Contributor

Hello!

Thanks for opening this issue, I'll be taking a stab at fixing this, since we shouldn't be BSD anymore.
Though I'll be asking our legal department what license should the nvml.h be as I'm not certain how the relicensing impacts that specific file.

GPL is only in the context of building using the system's libelf which is the case on PPC.

@jordimassaguerpla
Copy link

Hi,
I also noticed this in the RPM spec file.

So the spec file for the RPM states "License: BSD" https://github.com/NVIDIA/libnvidia-container/blob/master/pkg/rpm/SPECS/libnvidia-container.spec#L2, while the project is licensed under the apache 2 https://github.com/NVIDIA/libnvidia-container/blob/master/LICENSE, elftoolchain is bsd (https://github.com/elftoolchain/elftoolchain#copyright-and-license)and nvidia modprobe is GPL https://github.com/NVIDIA/nvidia-modprobe/blob/master/COPYING

Which should be the RPM license?

thanks

@Klaven
Copy link

Klaven commented Jun 16, 2020

Is there anything I can do to help resolve this issue?

@dcermak
Copy link

dcermak commented Jun 17, 2020

To make this more complicated, the list from @paroque28 is not exhaustive. A scan via fossa found the following licenses:

  • GPL-3.0-ONLY (COPYING)
  • LGPL-3.0-ONLY (COPYING.LESSER)
  • LGPL-3.0-OR-LATER (src/elftool.[c,h], NOTICE)
  • BSD-3-CLAUSE (the spec file)
  • APACHE-2.0 (declared license, LICENSE, mk/docker.mk)

To me it looks like putting LGPL-3.0-ONLY into COPYING.LESSER is an oversight, as it is explicitly noted that it applies when this library is linked against libelf.

Unfortunately I am afraid that this is all that we can do, the rest of the licensing is something that @RenaudWasTaken and NVIDIA must fix.

dannysauer pushed a commit to dannysauer/libnvidia-container that referenced this issue Jun 17, 2020
Update spec file license to reflect current state

Several parts of libnvidia-container (and dependencies) are not BSD-licensed, or are ambiguously-licensed.  This updates the spec file to reflect current state, including some comments so the reasoning isn't lost.  If NVIDIA#74 is resolved, this may change. :)

* elftoolchain is licensed under BSD-3-Clause
  https://github.com/elftoolchain/elftoolchain#copyright-and-license
* libnvidia-container is licensed under apache-2.0
  https://github.com/NVIDIA/libnvidia-container/blob/master/LICENSE
* libnvidia-container includes the GLPv3 license
  https://github.com/NVIDIA/libnvidia-container/blob/master/COPYING
* libnvidia-container includes the LGPLv3 license
  https://github.com/NVIDIA/libnvidia-container/blob/master/COPYING.LESSER
* nvidia-modprobe is licensed under GPLv2
  https://github.com/NVIDIA/nvidia-modprobe/blob/master/COPYING
* several (14) nvidia-modprobe files contain the MIT license header
  https://github.com/NVIDIA/nvidia-modprobe/blob/master/utils.mk
dannysauer pushed a commit to dannysauer/libnvidia-container that referenced this issue Jun 17, 2020
Update spec file license to reflect current state

Several parts of libnvidia-container (and dependencies) are not BSD-licensed,
or are ambiguously-licensed.  This updates the spec file to reflect current
state, including some comments so the reasoning isn't lost.  If NVIDIA#74 is
resolved, this may change. :)

* elftoolchain is licensed under BSD-3-Clause
  https://github.com/elftoolchain/elftoolchain#copyright-and-license
* libnvidia-container is licensed under apache-2.0
  https://github.com/NVIDIA/libnvidia-container/blob/master/LICENSE
* libnvidia-container includes the GLPv3 license
  https://github.com/NVIDIA/libnvidia-container/blob/master/COPYING
* libnvidia-container includes the LGPLv3 license
  https://github.com/NVIDIA/libnvidia-container/blob/master/COPYING.LESSER
* nvidia-modprobe is licensed under GPLv2
  https://github.com/NVIDIA/nvidia-modprobe/blob/master/COPYING
* several (14) nvidia-modprobe files contain the MIT license header
  https://github.com/NVIDIA/nvidia-modprobe/blob/master/utils.mk

Signed-off-by: Danny Sauer <dsauer@suse.com>
nvjmayo pushed a commit that referenced this issue Jun 24, 2020
Update spec file license to reflect current state

Several parts of libnvidia-container (and dependencies) are not BSD-licensed,
or are ambiguously-licensed.  This updates the spec file to reflect current
state, including some comments so the reasoning isn't lost.  If #74 is
resolved, this may change. :)

* elftoolchain is licensed under BSD-3-Clause
  https://github.com/elftoolchain/elftoolchain#copyright-and-license
* libnvidia-container is licensed under apache-2.0
  https://github.com/NVIDIA/libnvidia-container/blob/master/LICENSE
* libnvidia-container includes the GLPv3 license
  https://github.com/NVIDIA/libnvidia-container/blob/master/COPYING
* libnvidia-container includes the LGPLv3 license
  https://github.com/NVIDIA/libnvidia-container/blob/master/COPYING.LESSER
* nvidia-modprobe is licensed under GPLv2
  https://github.com/NVIDIA/nvidia-modprobe/blob/master/COPYING
* several (14) nvidia-modprobe files contain the MIT license header
  https://github.com/NVIDIA/nvidia-modprobe/blob/master/utils.mk

Signed-off-by: Danny Sauer <dsauer@suse.com>
@nvjmayo nvjmayo closed this as completed Aug 10, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

6 participants