Add CLI options to opt-out of socket injection #283
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
elezar
force-pushed
the
allow-socket-opt-out
branch
from
d375e03
to
0178a85
Compare
elezar
changed the title
elezar
force-pushed
the
allow-socket-opt-out
branch
from
0178a85
to
fbc72fe
Compare
cdesiniotis
reviewed
Sep 16, 2024
elezar
force-pushed
the
allow-socket-opt-out
branch
2 times, most recently
from
d3e7b9e
to
763f395
Compare
This change adds a no-persistenced option to the configure and list commands to allow users to opt-out of detecting and injecting the nvidia-persistenced socket into a container. Signed-off-by: Evan Lezar <elezar@nvidia.com>
This change adds a no-fabricmanager option to the configure and list commands to allow users to opt-out of detecting and injecting the nvidia-fabricmanager socket into a container. Signed-off-by: Evan Lezar <elezar@nvidia.com>
elezar
force-pushed
the
allow-socket-opt-out
branch
from
763f395
to
13f2046
Compare
cdesiniotis
approved these changes
Sep 17, 2024
klueska
reviewed
Sep 18, 2024
Comment on lines
+155
to
+162
| case 0x86: | ||
| if (str_join(&err, &ctx->driver_opts, "no-persistenced", " ") < 0) | ||
| goto fatal; | ||
| break; | ||
| case 0x87: | ||
| if (str_join(&err, &ctx->driver_opts, "no-fabricmanager", " ") < 0) | ||
| goto fatal; | ||
| break; |
There was a problem hiding this comment.
driver_opts needs to be freed since it might get allocated as part of this str_join() call
klueska
reviewed
Sep 18, 2024
Comment on lines
+75
to
+82
| case 0x84: | ||
| if (str_join(&err, &ctx->driver_opts, "no-persistenced", " ") < 0) | ||
| goto fatal; | ||
| break; | ||
| case 0x85: | ||
| if (str_join(&err, &ctx->driver_opts, "no-fabricmanager", " ") < 0) | ||
| goto fatal; | ||
| break; |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change allows command line options to the
nvidia-container-cliconfigureandlistcommands to opt-out of the detection and inclusion of thenvidia-persistencedandnvidia-fabricmanagersockets.